• Jeffrey Kardatzke's avatar
    Revert "media/gpu/chromeos/MailboxVFConverter: Set visible size to SharedImage" · a0bb0465
    Jeffrey Kardatzke authored
    This reverts commit 7d82db05.
    
    Reason for revert: This crashes. The frame pointer referenced on line 256 was std::move'd on line 240 so it is invalid.
    
    Original change's description:
    > media/gpu/chromeos/MailboxVFConverter: Set visible size to SharedImage
    > 
    > MailboxVideoFrameConverter sets coded size to SharedImage. It
    > causes that a green line is shown at the bottom and right edge
    > when playing a video.
    > 
    > This fixes the issue by setting visible size to SharedImage so
    > that GPU doesn't access non visible area.
    > Note that MailboxVideoFrameConverter needs to recreate
    > SharedImage if the visible rectangle of the current video frame
    > is changed, which should be rare though.
    > 
    > Bug: 1043582
    > Test: Play a 1080p video on soraka with --enable-features=ChromeosVideoDecoder
    > Change-Id: I76878a27fa92d755380d9b92b94d20e765056fac
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011586
    > Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    > Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#734795}
    
    TBR=mcasas@chromium.org,hiroh@chromium.org,acourbot@chromium.org
    
    Change-Id: Ieea5d53c3deb5aae963da4f6cdb82cc9648f8f44
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1043582
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020409Reviewed-by: default avatarJeffrey Kardatzke <jkardatzke@google.com>
    Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
    Cr-Commit-Position: refs/heads/master@{#735166}
    a0bb0465
mailbox_video_frame_converter.h 7.04 KB