GitLab

This reverts commit 7d82db05.

Reason for revert: This crashes. The frame pointer referenced on line 256 was std::move'd on line 240 so it is invalid.

Original change's description:
> media/gpu/chromeos/MailboxVFConverter: Set visible size to SharedImage
> 
> MailboxVideoFrameConverter sets coded size to SharedImage. It
> causes that a green line is shown at the bottom and right edge
> when playing a video.
> 
> This fixes the issue by setting visible size to SharedImage so
> that GPU doesn't access non visible area.
> Note that MailboxVideoFrameConverter needs to recreate
> SharedImage if the visible rectangle of the current video frame
> is changed, which should be rare though.
> 
> Bug: 1043582
> Test: Play a 1080p video on soraka with --enable-features=ChromeosVideoDecoder
> Change-Id: I76878a27fa92d755380d9b92b94d20e765056fac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011586
> Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
> Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#734795}

TBR=mcasas@chromium.org,hiroh@chromium.org,acourbot@chromium.org

Change-Id: Ieea5d53c3deb5aae963da4f6cdb82cc9648f8f44
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1043582
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020409Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#735166}

We assume this value to be min row bytes based on what the image cache
uses for decoded images. But this is not true for bitmaps that come from
the embedder directly (UI compositor).

R=ericrk@chromium.org

Bug: 1041477
Change-Id: I21fa8c8a60c2a71604a0aeeed1253ab199aee6a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020806
Commit-Queue: Khushal <khushalsagar@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735165}

Bug: 1038671
Change-Id: Ifb1fed6c3cca7badf85df8df92b1afbdf83bb614
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020529
Auto-Submit: Fritz Koenig <frkoenig@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735164}

Implements ReadAvailablePlatformSpecificFormatNames, which exposes all formats
available to platform clipboards and native applications. This includes formats
that Chrome does not normally sanitize, and excludes pickled formats not
normally exposed to underlying platform clipboards.

This functionality will begin behind a flag, and will not initially be exposed
to the web.

Design Doc: https://tinyurl.com/raw-clipboard-access-design

Bug: 897289
Change-Id: I6a93e89d01fa1412b61ec45f4dca881496b92c0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001752Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735163}

With this change only the app selected for the initial "pay" attempt
will be available during retry.

Bug: 1028098
Change-Id: I13815f19e86c2ca3413867ce17d04dc48862b98c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015826
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735162}

This reverts commit 216a16f9.

Reason for revert: See https://bugs.chromium.org/p/chromium/issues/detail?id=1044378#c5

Original change's description:
> mojo-js: Use bound generic type for PendingReceiver
>
> The Closure version used in Chromium now supports bounded generic types.
>
> Bug: 1015726
> Change-Id: I14c080b6e3cd67cbdf564312fc1c1686f3adb1e6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906691
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#714744}

TBR=rockot@google.com,ortuno@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1015726,1044378
Change-Id: Ic08c9baa69db14d9abf7a6f0ca64e4f9720b7cd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017902
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#735161}

Bug: 912320
Change-Id: I44eceafae715ccedfb258b86d53728efb401d28e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020783
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735160}

Since fefeda7b ("[Fuchsia] Remove unused services from test sandbox
CMX fragment."), we can't run any graphics tests because the sandbox does
not allow access to the requisite services.

Add a new sandbox config for these cases.

Bug: 766360

Change-Id: Ic09d3ce09947a348830d95827e965e7b8b7a442e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756386
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735159}

Certain chromebooks now come with panels that have integrated privacy
screens on them. This CL exposes an API in DisplayConfigurator to
set the KMS property, privacy-screen, to the desired state.

Bug: b/147451643
Test: tested locally on a test device
Change-Id: Iafa61365ce20c147eaa672cf33d8d3c6104bcb89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015648
Commit-Queue: Gil Dekel <gildekel@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735158}

Follow up CLs will wire the fetch API up to a loader as well as invoke
the fetch API from AssistantSuggestionsController at the appropriate
points in the Assistant lifecycle.

Bug: b:148239201
Change-Id: I8eb816aab3eff180b90d4eb21371d81b6219ce0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018443
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735157}

Change-Id: I82c593c48c33259e561fc03e0ff0657aadebdde3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021007
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735156}

Tested: Locally
Change-Id: I1684b5336b039ba0d742489aba65fb8bfc3a5421
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020560
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735155}

Windows appears to send two BluetoothAdapter::StateChanged events
whenever a Bluetooth adapter is powered up. At least the first such
event races against Windows-internal adapter initialization,
such that calls to BluetoothLEAdvertisementWatcher::Start can fail with
"device not ready for use" for some time after the first StateChanged.

Additionally, calling BluetoothAdapter::RegisterAdvertisement() twice
in a row appears to send things into a wonky state where callbacks stop
firing.

In combination, these quirks do not cause noticeable issues in most
environments: When the first StateChanged event following an adapter
power-on arrives, starting BLE discovery fails because starting the
advertisement watcher fails. By the time the second StateChange event
arrives, sufficient time has passed for discovery to start
successfully. As a result, RegisterAdvertisement() is only called a
single time.

On some machines however, the first attempt to start discovering does
*not* fail (perhaps because the machine is slow, or because post-power-
on adapter initialization is fast), resulting in two calls to
RegisterAdvertisement().

Work around all this by doing the following:

(1) Make FidoCableDiscovery remember the adapter power state and ignore
AdapterPoweredChanged() calls that don't really change state, in
order to avoid calling RegisterAdvertisement() multiple times.

(2) Hold off on starting discovery for 500ms after the first power-on
event.

This is admittedly a bit of a hack. The 500ms are somewhat arbitrary and
I don't really know if adapter initialization perhaps takes even longer
in other environments. A more sound strategy would perhaps be to
retry the calls that are known to fail spuriously, preferably at the
//device/bluetooth layer; and also to fix whatever makes multiple
calls to RegisterAdvertisement() break everything.

Bug: b/145224971
Change-Id: If5ec45ec2b964c28f480d2e24a41a4c9a292c0a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018498Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735154}

Bug: 1043237, 1013685
Change-Id: Ie089eef59d7fdd0ad0d5f4defff1abeac6a07aa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008612
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Auto-Submit: Hesen Zhang <hesen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735153}

This flag is used for two purposes:
1.) BrowserTests which would fail if system-keyboard-lock were enabled
    (this is because the test infra installs its own keyboard hook
     which prevents the test from running correctly)
2.) Chrome users who want to capture all browser key combos in
    fullscreen mode but do not want local OS combos to be captured.

I'm extending the flag expiry out by several milestones as we are
working on an update to the KeyboardLock API which would allow the
caller to specify whether to install the system keyboard hook or
not.  That would mean that we can satisfy the two use cases above
via the javascript API and the flag can be removed.  We are working
on the spec updates now so hopefully we'll have the feature
implemented early this year

Change-Id: Ie2d6915eeb6351c96dd67bcd06f34ca07317a6cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016349
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Auto-Submit: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735152}

GCPW registry entries.

Change-Id: Ib218c1553507468f93dfb9476c9b22d12ccd038a
Bug: 1044781
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011295
Commit-Queue: Tien Mai <tienmai@chromium.org>
Reviewed-by: Tien Mai <tienmai@chromium.org>
Auto-Submit: Rakesh Soma <rakeshsoma@google.com>
Cr-Commit-Position: refs/heads/master@{#735151}

Add decode logic to extract the settings from policy and set the value
into device settings. Besides, make sure the setting will be reloaded
whenever the policy updates.

Bug: 1040078
Change-Id: Idd6ef1966ded2b430ac05c63f0e026bcef3b47c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012033Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Anqing Zhao <anqing@google.com>
Cr-Commit-Position: refs/heads/master@{#735150}

The goal of this change is to avoid writing empty blob files in
IndexedDB solely to store the last_modified date.

This changes creates a migration for IndexedDB from v3 to v4. This
migration changes the way BlobInfos are encoded, and adds 'size' and
'last modified' to the 'File' BlobInfo.

Now that the metadata is changed, this change also avoids writing
'empty' files to disk. Previously this is where the last_modified time
was stored, but since that is now in the metadata these no longer need
to be written.

Bug: 1024966,1015214
Change-Id: I1309561373e0d917119fece4c552edd6ff6f5c18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014060
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735149}

For easier crash reporting, copy various crash information when list
item is long pressed. This allows copying variations keys and upload
info.

Bug: 948923
Test: Manual test copying crash info by long pressing list items
Change-Id: Iaf66d77482bf9fee1095f63fb3b829def203c4a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020923
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Auto-Submit: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735148}

Bug: None
Change-Id: Ia23f0a26712ec3d26b0e0e0edf7c9d8a75196535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017372Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735147}

https://chromium.googlesource.com/angle/angle.git/+log/453926f51ebd..23521ca334f9

git log 453926f51ebd..23521ca334f9 --date=short --first-parent --format='%ad %ae %s'
2020-01-24 jgilbert@mozilla.com Validate `context` before use in ValidateStreamConsumerGLTextureExternalAttribsNV.
2020-01-24 artyom@fb.com GL_OVR_multiview shouldn't be defined for WebGL spec'ed shaders
2020-01-24 jdarpinian@chromium.org Clamp array accesses when robust buffer access not available
2020-01-24 jmadill@chromium.org Fix undefined behaviour in ClearTest.
2020-01-24 jmadill@chromium.org Add feature flags to EGLPlatformParameters "tie".

Created with:
  gclient setdep -r src/third_party/angle@23521ca334f9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: timvp@google.com
Change-Id: I530317617c4223976e748c7553e26e57f982b1a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020508Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735146}

TBR: svenzheng@chromium.org
Bug: 1045619
Change-Id: I271a579b89d9c94f64fa6cb9c7a5daf55c7d948e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020566Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735145}

Fixed scope of enterprise management override for Windows tests.

Original change's description:
> Open captive portal login pages in popup windows in secure mode.
>
> Secure DNS will be disabled in these windows, allowing users to
> complete the captive portal resolution process.
>
> Future cls will add additional conditions that will trigger captive
> portal probes in secure mode.
>
> Change-Id: I441d17465a9c9d11567775321ed3ddd8532598ab
> Bug: 10161646
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984663
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Katharine Daly <dalyk@google.com>
> Cr-Commit-Position: refs/heads/master@{#734218}

Bug: 10161646
Change-Id: I23acfd00bc4f0558778e37fce1a8448ce1ac4ea0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016853
Commit-Queue: Katharine Daly <dalyk@google.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735144}

https://skia.googlesource.com/skia.git/+log/a7e557f3e353..b4cce3fa50ee

git log a7e557f3e353..b4cce3fa50ee --date=short --first-parent --format='%ad %ae %s'
2020-01-24 reed@google.com Revert "Revert "add rotate to SkM44""
2020-01-24 brianosman@google.com Make invokeChild just return a string containing the child function call
2020-01-24 reed@google.com Revert "add rotate to SkM44"
2020-01-24 bsalomon@google.com Detect implementation read formats on ES.
2020-01-24 reed@google.com add rotate to SkM44
2020-01-24 bungeman@google.com Preserve FcConfig in SkFontConfigInterface_direct methods.
2020-01-24 jvanverth@google.com Wrap page index packing in helper methods.
2020-01-24 bsalomon@google.com Revert "Revert "Move GrDomainEffect functionality into GrTextureEffect and delete""
2020-01-24 robertphillips@google.com Make GrGpu::createBackendTexture match createCompressedBackendTexture
2020-01-24 jvanverth@google.com Revert "Reland "Reland "Add new method for storing DrawOpAtlas texture index."""
2020-01-24 mtklein@google.com add skvm msan bot, move asan back to linux
2020-01-24 brianosman@google.com Remove invokeChild variants that write to output color
2020-01-24 mtklein@google.com clean up caches at thread exit
2020-01-24 mtklein@google.com link clang bots against our prepackaged libc++
2020-01-24 bsalomon@google.com Revert "Move GrDomainEffect functionality into GrTextureEffect and delete"
2020-01-24 ethannicholas@google.com Revert "Revert "Complete rewrite of the SkSL interpreter""
2020-01-24 bsalomon@google.com Move GrDomainEffect functionality into GrTextureEffect and delete
2020-01-24 mtklein@google.com silly hack -- move SkVM/ASAN bot to Mac
2020-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 7afe38da..2ae61982 (463 commits)
2020-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 135f8fcba837..f3b4e6c3030f (8 commits)
2020-01-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f324fe10ca65..5ef91b82cbed (6 commits)
2020-01-24 bsalomon@google.com Add support for GL_NV_fence.

Created with:
  gclient setdep -r src/third_party/skia@b4cce3fa50ee

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC benjaminwagner@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1004254,chromium:1040643,chromium:1045016
Tbr: benjaminwagner@google.com
Change-Id: I97b94bde3b74be69448d1e8eb409e201fdda3075
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020512Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735143}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/516ed977..ded3dd5b

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I3444a9a4f5875eb17eeff685f938af0dbbe60660
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020842Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735142}

Previously Skia was always using max texture size that it gets from the
GPU. In some scenarious it's useful to set a lower texture size limit.
Particularly it's useful in some configurations on Fuchsia to reduce
probablity that we fail to allocate a texture due to protected memory
fragmentation. The new --force-max-texture-size flag will allow to set
this value from command line.

Bug: fuchsia:43693
Change-Id: Ia55ee08e611f762a95ef285252a2ef9b9fa3bd90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018386
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735141}

Bug: 1006394
Change-Id: I522b48fc93f03b295928133bc4e647b92d262c26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016356Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735140}

This is a reland of 4c458a44. Disabled
the test that was flaking for now. I could only repro it once locally
after ~100 tries so disable it first to prevent the rest of the CL from
getting reverted.

Original change's description:
> cros: Remove ash-enable-overview-rounded-corners flags and reenable test.
>
> The rounded corners are here to stay. The test may have been related to
> the old impl of using layer masks. Anyhow, I added more reliable waits
> which also might help with the flakiness.
>
> Test: none
> Bug: 1000730, 941048
> Change-Id: I1ca619f37bc1646c741ba4500707269f17dbee29
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018166
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#734757}

TBR=ellyjones@chromium.org

Bug: none
Change-Id: Icb6c9981aed12170eb15b0eedd422b4a61d27c9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020509Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735139}

Bug: 1045050
Change-Id: I30ac10d34c2ea78cb94e4834f80edbbe019a16f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020423
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735138}

Make FidoCableDiscovery::StopAdvertisements() invoke its callback even if individual calls to BluetoothAdvertisement::Unregister() failed, and simplify it.

Also remove some unnecessary code sharing between FidoBleDiscovery and
FidoCableDiscovery.

Change-Id: I3bcb1839fbf84a5bf5e3c8dec16d858103243f25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018497
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735137}

Bug: 1045591
Change-Id: I4dd9a03bd576dbf2ad9c7adfc5a18c752db5ad89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020942Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735136}

Change-Id: I6b311605c30c150a47b8dac52e444d9ddf1a28a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019412Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735135}

This is just in preparation for future changes to how this class uses
IndexedDB.

Change-Id: Ic10969e970f90a62db064c2fa53a388ff63658e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020564
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735134}

The original change had been reverted/relanded several times so I
decided to just disable this test since it doesn't appear to be causing
problems on other bots.  That will save the author another revert/reland
cycle.

TBR: andrescj@chromium.org
Bug: 1045602
Change-Id: I75cde759769f1bbd399992d17f778736bbd03163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020803Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735133}

Following the naming conventions decided in
go/clank-preferences-refactor, this change replaces the "Preferences"
suffix with "Settings".

Bug: 1030446
Change-Id: Icc4f86b119194cc92716b5452711ea8dfafd8883
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014623Reviewed-by: Gang Wu <gangwu@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735132}

TBR=ajgo@chromium.org
R=ajgo@chromium.org

Bug: 1045564
Change-Id: Ibd82b6b2635f773df74467d45dfd390d3a9a0e79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020802Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735131}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/829bdae45d24..955353d9a221


Created with:
  gclient setdep -r src-internal@955353d9a221

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1023913,chromium:1028270,chromium:927262
Tbr: jbudorick@google.com
Change-Id: I0b60e8756d3bbbb4784ca793b9cb01abeff0c31d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020507Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#735130}

This might be the root cause of the tagged issue, though it is no longer
reproducible.

Note that layout is already invalidated when the title changes, for
ostensibly the same reason.

Bug: 1038448
Change-Id: I3f4e40d8450fc1a96da1d0c1b1e6e9b2c9ac661e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018487Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735129}

This replaces app state observing with tabbed activity observing. One
key difference is that tabbed activity does not include CCT. We only
want to preconnect DSE for non-CCT chrome foreground.

Bug: 1041118
Change-Id: I9e88e15c11cdfd7d13078a71c680be31c9b05932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006478
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735128}

$document exception rules can be implemented using allowAllRequests action type.

BUG=1038831

Change-Id: Iab90eff5923ad76b3091f54479c1cafe33e92a1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005113
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735127}