-
Giovanni Ortuño Urquidi authored
This reverts commit ff026011. Reason for revert: AddToHomescreen tests failing on Android CFI https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3851 JNI ERROR (app bug): expected jboolean (0/1) but got value of 255 as argument 2 to void org.chromium.chrome.browser.webapps.AddToHomescreenManager.onIconAvailable(android.graphics.Bitmap, boolean) Original change's description: >
👹 Add adaptable homescreen shortcuts for maskable icons. > > The Add to Homescreen feature will now consider "maskable" icons from > the web app manifest [1]. If a maskable icon is present and we are on > an Android O+ device, turn that "maskable" icon into an Android Adaptive > icon [2]. > > The icon is scaled to ensure that the safe zone is preserved [3]. > > [1]: https://w3c.github.io/manifest/#purpose-member > [2]: https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive > [3]: https://github.com/w3c/manifest/issues/555#issuecomment-404097653 > > Bug: 904354 > Change-Id: Iedfe61ace0fda4ca7f3ed3da6a5d07f2bff81443 > Reviewed-on: https://chromium-review.googlesource.com/c/1341998 > Commit-Queue: Peter Conn <peconn@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612218} TBR=yfriedman@chromium.org,peter@chromium.org,mgiuca@chromium.org,peconn@chromium.org,dominickn@chromium.org Change-Id: I2cccbcbd5fc01f68e1004516b470465db1e663ac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904354 Reviewed-on: https://chromium-review.googlesource.com/c/1356166Reviewed-by:Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612513}
aa1f1cca