• Takashi Toyoshima's avatar
    Reland "Reland "Reland "Split WebKit platform build file""" · ab4da6c8
    Takashi Toyoshima authored
    blobs.mojom-blink.h internally depends on url.mojom-blink.h.
    So, we should have //url/mojo:url_mojom_gurl_blink__generator
    dependency in blob:generator target on which other test_support
    source_set depends.
    
    confirmed that generated ninja files, i.e.
    ../obj/third_party/WebKit/Source/platform/loader/test_support.ninja
    has a dependency to obj/url/mojo/url_mojom_gurl_blink_generator.stamp
    
    This is a reland of 1cf9f36e
    Original change's description:
    > Reland "Reland "Split WebKit platform build file""
    > 
    > test_support of platform/loader and platform/network should
    > depends on //storage/public/interfaces:interfaces_blink__generator
    > because it indirectly includes generated mojo interface headers.
    > 
    > This is the root cause of the original issue, and it seems
    > BUILD file splitting makes it happens more easily.
    > 
    > This is a reland of 997ce7ad
    > Original change's description:
    > > Reland "Split WebKit platform build file"
    > > 
    > > platform/network/BUILD.gn lacked mojo_bindings_blink dependency.
    > > This caused a race on compiling.
    > > 
    > > This is a reland of 080c70a7
    > > Original change's description:
    > > > Split WebKit platform build file
    > > > 
    > > > A race condition was found in the build of //third_party/WebKit/Source/platform/loader.
    > > > To resolve it necessary to extract targets  //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed.
    > > > All of these done in this CL.
    > > > 
    > > > Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it
    > > > to submit since it needs quick rebase works to catch up HEAD.
    > > > 
    > > > Bug: 754600
    > > > Change-Id: I5f70348fac10f270df99b658608cf23685ed937e
    > > > Test: gn check out/Release && ninja -C out/Release
    > > > Reviewed-on: https://chromium-review.googlesource.com/612284
    > > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
    > > > Reviewed-by: Daniel Bratell <bratell@opera.com>
    > > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
    > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > > > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#508661}
    > > 
    > > TBR=engedy@chromium.org
    > > 
    > > Bug: 754600
    > > Change-Id: I250e67581e61e1d36c32b01ccad3372b442c08bc
    > > Reviewed-on: https://chromium-review.googlesource.com/718243
    > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
    > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#508993}
    > 
    > TBR=engedy@chromium.org
    > 
    > Bug: 754600
    > Change-Id: Ia1231a3ee2213bb44474bd8ffeacf67b86002bfd
    > Reviewed-on: https://chromium-review.googlesource.com/720542
    > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
    > Reviewed-by: Emil A Eklund <eae@chromium.org>
    > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#509359}
    
    TBR=jam@chromium.org
    
    Bug: 754600
    Change-Id: Ica01cdfc20e7cf26e1adf4c42a5fae7ac83a310e
    Reviewed-on: https://chromium-review.googlesource.com/725139Reviewed-by: default avatarTakashi Toyoshima <toyoshim@chromium.org>
    Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#509749}
    ab4da6c8
BUILD.gn 5.28 KB