• Adam Rice's avatar
    Fix race condition with WebSocket shutdown · adb77dad
    Adam Rice authored
    There was a race condition in the network service where if a disconnect
    on the writing or reading data pipes was detected before the disconnect
    on the mojo interfaces it would fail to send a close frame. To fix, stop
    resetting the connection when the data pipes are closed.
    
    Re-enable the SendCloseFrameWhenTabIsClosed browser test. It should no
    longer be flaky, and it's the only test we have for this behaviour.
    
    Also modify the SendCloseFrameWhenTabIsClosed test to no longer timeout
    on failure.
    
    BUG=1123349
    
    Change-Id: Ib4aaa46cb1f9f97e09509f59ef421228d02c941d
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398036
    Commit-Queue: Adam Rice <ricea@chromium.org>
    Reviewed-by: default avatarYutaka Hirano <yhirano@chromium.org>
    Reviewed-by: default avatarMaksim Orlovich <morlovich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#810463}
    adb77dad
websocket_browsertest.cc 19.6 KB