• Devlin Cronin's avatar
    [Extensions Cleanup] Remove v8_helpers::SetProperty() · b17e66da
    Devlin Cronin authored
    v8_helpers::SetProperty() just wraps Object::DefineOwnProperty().
    However, with it, we lose the WARN_UNUSED_RESULT on the method, which
    can lead to dangerous assumptions or not handling edge cases. The method
    also doesn't really save us anything (the call to DefineOwnProperty is
    pretty concise).
    
    Remove v8_helpers::SetProperty(), and just use DefineOwnProperty
    directly.
    
    Bug: None
    Change-Id: I261ef1dc4f59f9541067f9fb87a115e49b32dc8d
    Reviewed-on: https://chromium-review.googlesource.com/896372
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#533763}
    b17e66da
module_system.cc 32.3 KB