[Extensions Cleanup] Remove v8_helpers::SetProperty()

v8_helpers::SetProperty() just wraps Object::DefineOwnProperty().
However, with it, we lose the WARN_UNUSED_RESULT on the method, which
can lead to dangerous assumptions or not handling edge cases. The method
also doesn't really save us anything (the call to DefineOwnProperty is
pretty concise).

Remove v8_helpers::SetProperty(), and just use DefineOwnProperty
directly.

Bug: None
Change-Id: I261ef1dc4f59f9541067f9fb87a115e49b32dc8d
Reviewed-on: https://chromium-review.googlesource.com/896372
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533763}

extensions/renderer/module_system.cc

@@ -468,19 +468,22 @@ void ModuleSystem::LazyFieldGetterInner(
   v8::Local<v8::Value> val = info.This();
   if (val->IsObject()) {
     v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(val);
-    auto maybe = object->Delete(context, property);
-    if (!maybe.IsJust()) {
+    auto maybe_deleted = object->Delete(context, property);
+    if (!maybe_deleted.IsJust()) {
       // In theory, deletion should never result in throwing an error. But
       // crazier things have happened.
       NOTREACHED();
       return;
     }
-    if (!maybe.FromJust()) {
+    if (!maybe_deleted.FromJust()) {
       // Deletion can *fail* in certain cases, such as when the script does
       // Object.freeze(chrome).
       return;
     }
-    SetProperty(context, object, property, new_field);
+    auto maybe_set = object->CreateDataProperty(context, property, new_field);
+    // Setting a new value can fail in multiple scenarios. Bail out if it does.
+    if (!maybe_set.IsJust() || !maybe_set.FromJust())
+      return;
   } else {
     NOTREACHED();
   }

extensions/renderer/v8_helpers.h

@@ -53,18 +53,6 @@ inline bool IsTrue(v8::Maybe<bool> maybe) {
   return maybe.IsJust() && maybe.FromJust();
 }
 
-// SetProperty() family wraps V8::Object::DefineOwnProperty().
-// Returns true on success.
-// NOTE: Think about whether you want this or SetPrivateProperty() below.
-// TODO(devlin): Sort through more of the callers of this and see if we can
-// convert more to be private.
-inline bool SetProperty(v8::Local<v8::Context> context,
-                        v8::Local<v8::Object> object,
-                        v8::Local<v8::String> key,
-                        v8::Local<v8::Value> value) {
-  return IsTrue(object->DefineOwnProperty(context, key, value));
-}
-
 // Wraps v8::Object::SetPrivate(). When possible, prefer this to SetProperty().
 inline bool SetPrivateProperty(v8::Local<v8::Context> context,
                                v8::Local<v8::Object> object,