• Yu Han's avatar
    Reland "[Controls Refresh Android] Fixes input missing border" · b1ce4a4e
    Yu Han authored
    This is a reland of 909901eb
    
    The revert was due to greater pixels error difference between
    Mac 10.12 & 10.15 and the baseline.
    
    After checking the error rate on failed Mac bots, the fix is
    to increase the error_pixels_percentage_limit from 9f to 10.2f in
    form_controls_browsertest::FuzzyPixelComparator.
    
    Original change's description:
    > [Controls Refresh Android] Fixes input missing border
    >
    > Prior to this CL, controls-refresh text input is missing its border.
    >
    > The fix is to make sure property text_field.has_border is passed to
    > native theme. This property is only used by form controls-refresh
    > so it has no impact on existing text input.
    >
    > Bug: 1155397
    > Change-Id: I3cacd4d9550e10388b15122d7ff94a32ffa5e39d
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612495
    > Reviewed-by: Camille Lamy <clamy@chromium.org>
    > Reviewed-by: Mason Freed <masonfreed@chromium.org>
    > Commit-Queue: Yu Han <yuzhehan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#841106}
    
    Bug: 1155397, 1164011
    Change-Id: I6f06173f677b45664ff4cb6dedfb9197b8ece95b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618675Reviewed-by: default avatarMason Freed <masonfreed@chromium.org>
    Reviewed-by: default avatarCamille Lamy <clamy@chromium.org>
    Commit-Queue: Yu Han <yuzhehan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#842590}
    b1ce4a4e
form_controls_browsertest.cc 6.81 KB