• Matt Wolenetz's avatar
    MSE: Improve top-level mp4 box anomaly logging · b286003c
    Matt Wolenetz authored
    Reduces confusion between a couple top-level mp4 box log messages:
    1) BoxReader::IsValidTopLevelBox() issues a MEDIA_LOG if an unrecognized
       top-level box is found in the path that returns false, and typically
       results in parse error. Since I could find no caller which allows
       this to proceed without parse error, I changed this from a DEBUG to
       an ERROR to give web apps more visibility into the root cause via
       MediaError.message. (Caveat, until bug 1099034 is fixed, the more
       generic "stream parsing failed" error replaces the more specific, new
       parse error added in this change.)
    2) Mp4StreamParser::ParseBox() issued a similarly-worded DVLOG if there
       is a top-level box that *is* valid, but is skipped over. This change
       removes the confusing word "unrecognized" from this DVLOG, since the
       box is recognized as valid, but is just not parsed in detail.
    
    TEST=(For #1) Updated BoxReaderTest.WrongFourCCTest
    BUG=1096273,1099034
    
    Change-Id: I5525119177343465a8046aaa6dec3f7993a4caec
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264510
    Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org>
    Reviewed-by: default avatarDan Sanders <sandersd@chromium.org>
    Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#782621}
    b286003c
box_reader.cc 7.98 KB