• Victor Costan's avatar
    AppCache: Merge AppCacheJob and AppCacheURLLoaderJob. · b9693954
    Victor Costan authored
    AppCacheURLLoaderJob is the only subclass of AppCacheJob. This is a
    vestige of the Network Service migration, which introduced the
    AppCacheJob base class with two implementations.
    
    This CL merges AppCacheJob and AppCacheURLLoaderJob, and renames the
    result to AppCacheURLLoader. The new name is more appropriate in a
    Network Service-only world, and removes the potential for confusion
    with AppCacheUpdateJob.
    
    The following replaces were done mechanically over the entire
    repository:
    * AppCacheURLLoaderJob -> AppCacheURLLoader
    * AppCacheJob -> AppCacheURLLoader
    * appcache_url_loader_job.h -> appcache_url_loader.h
    * appcache_job.h -> appcache_url_loader.h
    * GetDerivedWeakPtr -> GetWeakPtr
    * appcache_url_loader_job -> appcache_url_loader
    
    AppCacheJob::AsURLLoaderJob() was removed, as it became a no-op after
    the class merger. The mechanical replaces above removed
    AppCacheURLLoaderJob::GetDerivedWeakPtr(), which became a synonym for
    GetWeakPtr().
    
    When relevant, job / Job was replaced with loader / Loader in local
    variable names and method names.
    
    This CL does not introduce any functional change.
    
    Change-Id: I5a508a8dcb14ec77da05dd345d280ea27fa12fa5
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066298
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Reviewed-by: default avatarJoshua Bell <jsbell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#743485}
    b9693954
appcache_request.h 3.11 KB