• Stephen Nusko's avatar
    Revert "Migrate chime dfm definition downstream" · ba4e63fc
    Stephen Nusko authored
    This reverts commit b83b94de.
    
    Reason for revert: crbug/1143787 broke android perf bot build
    
    ERROR at //clank/features/chime/BUILD.gn:6:1: Unable to load "/b/s/w/ir/cache/builder/src/chrome/android/modules/chime/chime_module.gni".
    import("//chrome/android/modules/chime/chime_module.gni")
    ^-------------------------------------------------------
    See //build/config/android/internal_rules.gni:2432:20: which caused the file to be included.
            _deps += [ "${_target_label}__assetres" ]
                       ^---------------------------
    
    Original change's description:
    > Migrate chime dfm definition downstream
    >
    > chime is a downstream only DFMs, it should be defined downstream only
    > and not reference clank from the chromium repo.
    >
    > Followup downstream cl crrev.com/i/3358245
    >
    > Change-Id: I54b4cc29cbb23c61f654fe86831f0e5c2f512d95
    > Bug: 1142775
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495608
    > Reviewed-by: Xing Liu <xingliu@chromium.org>
    > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
    > Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#822269}
    
    TBR=agrieve@chromium.org,xingliu@chromium.org,mheikal@chromium.org
    
    Change-Id: I299777b981d11776298848e9a0d5a02dd82d068f
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1142775,1143787
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508290
    Auto-Submit: Stephen Nusko <nuskos@chromium.org>
    Reviewed-by: default avatarStephen Nusko <nuskos@chromium.org>
    Commit-Queue: Stephen Nusko <nuskos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#822284}
    ba4e63fc
BUILD.gn 151 KB