• Elad Alon's avatar
    Deflake WebRtcInternalsTest · c89aa943
    Elad Alon authored
    The tests were flaky because of a race with
    WebRtcEventLogManager::task_runner_. The problem is that
    SequencedTaskRunner's destructor does not block, allowing us to destroy
    a WebRtcEventLogManager objects while its |task_runner_| is still
    executing a task that operates on the WebRtcEventLogManager object.
    
    We solve this by making WebRtcEventLogManager work synchronously when
    it's used in WebRTCInternals' unit tests (but nowhere else).
    
    Bug: 796047
    Change-Id: I76606b9394c1e5c02a3626fd8d3824bea587d1e4
    Reviewed-on: https://chromium-review.googlesource.com/850697
    Commit-Queue: Elad Alon <eladalon@chromium.org>
    Reviewed-by: default avatarMiguel Casas <mcasas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#527083}
    c89aa943
webrtc_event_log_manager.h 8.71 KB