• Rakina Zata Amni's avatar
    Reland "DL: Fix flaky getFullAXTree & wrongly updated accessibility tests" · cf83c6bc
    Rakina Zata Amni authored
    This is a reland of 2000b5b1
    
    Got reverted because of MSAN failure didn't run the msan bot one last time before
    submitting yesterday after I changed some things to use skip-viewport-activation, oops.
    The MSAN failure is because we never initialize the enum ax::mojom::NameFrom  in
    InspectorAccessibilityAgent::FillCoreProperties when the ax object is a display:none node
    within a locked subtree, so I set a default value for it, and it doesn't fail now!
    
    Original change's description:
    > DL: Fix flaky getFullAXTree & wrongly updated accessibility tests
    >
    > A devtoools display locking a11y test was marked as failing in MSAN bots
    > and is also flaky when tested locally, this CL updates that test and
    > fixes the cause of the failure (getFullAXTree might be called when
    > style/layout is dirty, which caused failing DCHECKs).
    >
    > Some other display locking a11y tests were not updated correctly, and is
    > updated in this CL as well.
    >
    > Bug: 996625
    > Change-Id: I32eac1385c54eb07b1e6dab800620a2485158437
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846618
    > Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
    > Reviewed-by: vmpstr <vmpstr@chromium.org>
    > Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#706834}
    
    Bug: 996625
    Change-Id: I168e40614ab600d1bd11f5cf97c166fa95400213
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866338Reviewed-by: default avatarAlice Boxhall <aboxhall@chromium.org>
    Reviewed-by: default avatarvmpstr <vmpstr@chromium.org>
    Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#708131}
    cf83c6bc
activatable.html 362 Bytes