-
Findit authored
This reverts commit ff41c36d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 715133 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZmNDFjMzZkY2UzZTUzYmZjYWQ2Y2VkZGMxZmMyOWU2MjBhNGYxMTcM Sample Failed Build: https://ci.chromium.org/b/8896853113607982064 Sample Failed Step: unit_tests Original change's description: > WebApp: Improve WebAppSyncBridge::UpdateSync to use both app states. > > Improve WebAppSyncBridge::UpdateSync to use both current_state (before commit) > and new_state (to be commit). > > In the future, it will help to skip local updates which don't touch sync data. > > Add WebAppSyncBridge::CommitUpdate unit tests (a.k.a. Local Changes). > > These tests is a promised follow up for this CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1830494 > > This code is disabled by default behind kDesktopPWAsWithoutExtensions and > kDesktopPWAsUSS base features. > > Bug: 860583 > Change-Id: I51dfda8b6364e15f9b5eb398321d6010241b0ae9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914005 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715133} Change-Id: Ia74c5f3586de10d9931ae8e23cd8deda44230508 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915545 Cr-Commit-Position: refs/heads/master@{#715170}
d9bcfac1