- 14 Nov, 2019 40 commits
-
-
Findit authored
This reverts commit ff41c36d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 715133 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZmNDFjMzZkY2UzZTUzYmZjYWQ2Y2VkZGMxZmMyOWU2MjBhNGYxMTcM Sample Failed Build: https://ci.chromium.org/b/8896853113607982064 Sample Failed Step: unit_tests Original change's description: > WebApp: Improve WebAppSyncBridge::UpdateSync to use both app states. > > Improve WebAppSyncBridge::UpdateSync to use both current_state (before commit) > and new_state (to be commit). > > In the future, it will help to skip local updates which don't touch sync data. > > Add WebAppSyncBridge::CommitUpdate unit tests (a.k.a. Local Changes). > > These tests is a promised follow up for this CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1830494 > > This code is disabled by default behind kDesktopPWAsWithoutExtensions and > kDesktopPWAsUSS base features. > > Bug: 860583 > Change-Id: I51dfda8b6364e15f9b5eb398321d6010241b0ae9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914005 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715133} Change-Id: Ia74c5f3586de10d9931ae8e23cd8deda44230508 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915545 Cr-Commit-Position: refs/heads/master@{#715170}
-
Peter Kotwicz authored
BUG=1020911 Change-Id: Ife359e136de30b71e829bfadb2f35eb7b9968734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907714 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#715169}
-
Anastasia Helfinstein authored
Currently, when a user launches Switch Access, they cannot control it because they have to configure their switches. This change has Switch Access check if the configured settings allow for navigation, and if not opens the Switch Access settings page. Bug: 996387 Change-Id: I7c85841e7511eb96726187a4db8b127d6f4820bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902233 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#715168}
-
Kyle Ju authored
Design doc: https://docs.google.com/document/d/1MtdbUcWBDZyvmV0FOdsTWw_Jv16YtE6KW5BnnCVYX4c/edit#heading=h.7nki9mck5t64 Running Command: python third_party/blink/tools/wpt_export.py --dry-run --credentials <your credentials> --surface-failures-to-gerrit Tested on a mock CL https://chromium-review.googlesource.com/c/chromium/src/+/1784803 Change-Id: I368d6fc5b0f7f3e5364fca1fe26cef3514585f96 Bug: 996383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749720 Commit-Queue: Kyle Ju <kyleju@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#715167}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed9254941c7a..2685ecce9083 Created with: gclient setdep -r src-internal@2685ecce9083 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1019994 Change-Id: Iadf5dca9810cb841aada0ddba57a8b751cb8e79e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915403Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715166}
-
Alan Screen authored
During print preview when the PDF compositor is used, individual PDFs for each page are made for the preview. Prior art has the full document PDF used for printing being generated by sending a separate metafile blob for all the pages, which is overly large for long documents. This alters that to have the full document PDF get composited using the same individual page metafile objects as they are sent to the utility process for the composition. This effectively halves the amount of IPC traffic for Skia metafile data and eliminates potential huge metafile messages that can overwhelm IPC limits. This is only applicable for print preview scenarios that pass Skia metafile into PDF compositor. Non-modifiable content and basic printing are unaffected in behavior. Bug: 872935 Change-Id: I1101846a00498956b18c208ada656e65e4f175a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616461 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#715165}
-
Azeem Arshad authored
This CL fixes issue with manual proxy config exception list items being read out incorrectly in ChromveVOX and removes unnecessary tab stop. Fixed: 1024355 Change-Id: Ie2a24f36c072a7b451135a274d0ec15320a924c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915319Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715164}
-
khmel@chromium.org authored
This reverts commit 3c419198. Reason for revert: This is important feature and should not be reverted. It is possible to mark flaky test as Disabled, flakiness is just from test environment. TBR=xiyuan@chromium.org,isherman@chromium.org BUG:1013148 BUG=b:142251935 Original change's description: > Revert "arc: Provide replacement for deprecated PlayStoreShown UMA" > > This reverts commit dcdf3924. > > Reason for revert: Flaky on linux-chromeos-rel, see https://crbug.com/1013148 > > Original change's description: > > arc: Provide replacement for deprecated PlayStoreShown UMA > > > > This rolls new set of UMA that replaces derpecated PlayStoreShown UMA > > DD: > > https://docs.google.com/document/d/1vfJMzoYsXtH-HWYydbb5VJvpT6WeJrfvaO81RHI5v2M/edit > > > > BUG=b:142251935 > > TEST=Locally + unit tests. > > > > Change-Id: Ie2ec139b41e702dda604d92324b426782ed494ce > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845935 > > Commit-Queue: Yury Khmel <khmel@chromium.org> > > Reviewed-by: Ilya Sherman <isherman@chromium.org> > > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#704384} > > TBR=xiyuan@chromium.org,yusukes@chromium.org,isherman@chromium.org,khmel@chromium.org > > Change-Id: Ie870309e4d2b879679e79d3b468736e51bab096f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b:142251935, 1013148 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852785 > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704615} TBR=xiyuan@chromium.org,yusukes@chromium.org,isherman@chromium.org,drott@chromium.org,khmel@chromium.org Bug: b:142251935, 1013148 Change-Id: Ie22a50f720b4e1a90a8072e32267f089e7862ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913419Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715163}
-
Lambros Lambrou authored
The remoting_me2me_host binary supports 2 command-line options, for checking Accessibility and Screen Recording permissions on MacOS. This CL adds the same options to the IT2Me native-messaging host. Bug: 1013446 Change-Id: I4727e5f58f70580f8f31c551968238a4d49457f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914834Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#715162}
-
Demetrios Papadopoulos authored
This is in preparation of migrating to Polymer3. There is no clear benefit of keeping these scripts separated anymore, and it does get in the way of making the optimized Polymer3 version from working correctly. Bug: 1022215 Change-Id: I40e29c2f22b687e8ba9bad076bc6f6a16ce95731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914833Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715161}
-
Kyle Horimoto authored
When configuring networks, the networking UI compiles a dictionary of properties describing the new network to configure. In this particular case, the "clientCertPkcs11Id" field of the dictionary was misspelled using capital letters: "clientCertPKCS11Id". This CL corrects the spelling and fixes this connection flow. Bug: 1019936 Change-Id: I421c340a36c3a8b9404b07e76aa86f6cffae9829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915279 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#715160}
-
Benoît Lizé authored
Large chunks are suspected to be the cause for the linked bug (address space fragmentation). Speculatively use a smaller chunk size to confirm the theory. Only use a smaller size on Windows 32, as this increases the number of file descriptors on all platforms, and the underlying issue (address space fragmentation) is almost impossible on 64 bit architectures, and very unlikely on Android. Bug: 983348 Change-Id: Ic3ecc0a37f712be3fa6d45dfb01326b651f3f470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915379Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#715159}
-
Joshua Peraza authored
https://chromium.googlesource.com/linux-syscall-support.git/+log/8048ece6c16c..726d71ec08d1 $ git log 8048ece6c..726d71ec0 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 jperaza Add sigtimedwait and sigprocmask wrappers Created with: roll-dep src/third_party/lss Change-Id: I4dbbeaf72f432caab2315779e0305a60b78a1ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915182 Commit-Queue: Mike Frysinger <vapier@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#715158}
-
Etienne Bergeron authored
This CL is refactoring the way codepoints are rewritten for the conversion between text to layout_text. There is an invariant that must hold: * Same amount of codepoint The text size may differ and text indexes are not the same. This CL is proposing to use a map function to replace codepoints. This avoid error-prone custom codepoints replacement. Bug: 1022893 Change-Id: Ic1fcdfe6b34a1bf1dd47f0ee6a5e157bd131d0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908447 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#715157}
-
Darren Shen authored
Delaying expiry of enable-cros-ime-input-logic-fst to M85, to match enable-cros-ime-native-decoder. Change-Id: I6dc14a97b702b959924a178b35bd3d197aaab252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914585 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#715156}
-
Yue Li authored
Bug: b/144383302 Test: Manual Test Change-Id: I738416312657739686b7a303cc3aa79355695e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915286 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#715155}
-
Lin Sun authored
Extract driver vendor from ANGLE's renderer description according to the format implemented in OpenGL and Vulkan backend. Bug: 994852 Change-Id: I0b72166b504f1a83762a12f1d574c8cd20bf9df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903404Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Lin Sun <lin.sun@intel.com> Cr-Commit-Position: refs/heads/master@{#715154}
-
Matt Reynolds authored
SCUF Vantage gamepads are designed to work with Playstation 4 consoles and behave mostly the same as genuine Sony DualShock 4 gamepads, but expose a different vendor and product ID. Both SCUF Vantage and SCUF Vantage 2 expose the same IDs (2e95:7725). This CL enables Dualshock4Controller to recognize the SCUF Vantage and Vantage 2 as PS4-compatible devices and applies the mapping functions used for DualShock 4. BUG=1017414 Change-Id: Ic55dc5d2b36c456061eb8bb76b0d0c9f0b85a1d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880635Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#715153}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6006105f67c3..37be7715fdd1 git log 6006105f67c3..37be7715fdd1 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 mtklein@google.com implement assert_true on ARM 2019-11-13 brianosman@google.com Move the persistent GrMemoryPool to the heap Created with: gclient setdep -r src/third_party/skia@37be7715fdd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: I8ab9e73dfaee4712a2c8c67132ba8ad4204fc233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715152}
-
Sammie Quon authored
This reverts commit 851088cf. Reason for revert: This is wrong fix. Original change's description: > overview: Close button is not layouted properly. > > Gave the parent a rect that has x-bounds, but still using the parent's > parent width, resulting in a overflow. > > Test: manual > Bug: 1020539 > Change-Id: I983cf0813c6b99a74960761c8c8fd241b2995e0e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914942 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715105} TBR=afakhry@chromium.org,sammiequon@chromium.org Change-Id: Iea026b292493d8c9ca0931d6a40606e053bda2b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1020539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914796Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#715151}
-
Mohammad Refaat authored
The feature was launched in stable for some time. Bug: 850760, 774736 Change-Id: I763ddbd5a83d3686cb1cff7336041fd5c729847d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913183Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#715150}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d85c18b05dcf..8bc4fa870170 git log d85c18b05dcf..8bc4fa870170 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 achuith@chromium.org OWNERS: Add Amin to devserver-related files. 2019-11-13 ahassani@chromium.org paygen: Fix UnofficialSignerPayloadClient with python3 2019-11-13 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@8bc4fa870170 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia8f9ce607b56ba36e8206fedf06aced0a0d7a1a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914864Reviewed-by:
-
Rakib M. Hasan authored
Changes to typ may cause the number of values returned from GetExpectationsForTest to change. We only want the first 2 values in gpu test code. Bug: chromium:986447 Change-Id: Iec3dbf25b14e24af774ad5656bd63d94e5ee8a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915183Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#715148}
-
Ken Rockot authored
Services ported to the newer service model have not been logging their service name in the "service-name" crash key used by other services. That can make utility process crashes difficult to pinpoint on a specific service. This ensures that all services stash their name in the "service-name" crash key. Note that unlike in the old model, there is no concept of "service name" beyond the name of a service's primordial Mojo interface; so that's what's logged in these cases. Bug: 1024560 Fixed: 1024601 Change-Id: I98f8887925e2e0012b6f281db5df31ccd97cb40b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912838Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#715147}
-
Ryan Hamilton authored
Change-Id: I10d3f8ff2bde72db39dd7e26b73c82a7f9155e4a Bug: 1024613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913968 Commit-Queue: Ryan Hamilton <rch@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#715146}
-
Andrew Grieve authored
Has been unused for multiple years. TBR=agrieve # Trivial build refactor Change-Id: I45ffeb9038896e34221569b13fe81aeec5a02eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914977 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#715145}
-
Yusuf Sengul authored
Bug: 1024404 Change-Id: Icffc3a1e1bea5ed2aa7ae0778161e29fc4ff267a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914824 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#715144}
-
Bailey Berro authored
Adds the name of the user to the tooltip shown on the "Remove" button in the "Restrict sign-in to the following users" list. If a user's name is available, we use that. Otherwise, we use their displayEmail. This provides additional context on the tooltip and ensures that ChromeVox can provide enough context to users Bug: 825943 Change-Id: I07c77d4a8a70fa76accd23a0738047f06447781c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913050 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#715143}
-
Mikel Astiz authored
Recent patches introduced the initialization of FieldTrialList as part of the test suite, hence it's no longer necessary to do so explicitly. This patch addresses unit tests related to metrics and variations. Bug: 1018667 Change-Id: If091b24ca3a4943841228d850c0166c14ffb3db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884730Reviewed-by:
-
Robbie McElrath authored
WebView's apk subfolder is used to store all code that runs under WebView's UID rather than as part of a library loaded by other apps. 'nonembedded' more clearly and accurately reflects this than 'apk'. In order not break clank, this CL temporarily creates a copy of AndroidManifest.xml that will be deleted as soon as downstream is updated to use the new path. TBR=fgorski@chromium.org Test: ninja -C out/aw Bug: 934152 Change-Id: Icdbe95634701e7e6f31a3e3865ca80d9cbad47c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900130 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#715141}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4b642a6d90f5..f533355b4140 git log 4b642a6d90f5..f533355b4140 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src d287523f48db..d42d0747ee1b (6 commits) 2019-11-13 syoussefi@chromium.org Vulkan: Fix glMemoryBarrier* implementation 2019-11-13 cnorthrop@google.com ES31: Update Vulkan skip list for SSBO Created with: gclient setdep -r src/third_party/angle@f533355b4140 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:None Change-Id: I05f1a8c49cf01ae49fe1668044491528a117e5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914863Reviewed-by:
-
David Tseng authored
Html5 imports disabled by https://chromium-review.googlesource.com/c/chromium/src/+/1869562 breaks the cr-expand-button import. Change-Id: I5ca54381b04949f2fe76c4331c856ecbde34a005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914825 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#715139}
-
Alex Newcomer authored
The HomeLauncher used to use the default background type. This means that some transitions (clamshell no windows -> tablet mode no windows) will result in the ShelfWidget::DelegateView::opaque_background_ not being updated. Introduce this new type, which probably deserved to exist before this. Bug: 1020721 Change-Id: I40d4d86ac0ebd7348eb91f47df4976b146ba310c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914975 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#715138}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f901c4c03461..ed9254941c7a Created with: gclient setdep -r src-internal@ed9254941c7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:b/275781744,chromium:b/279249686,chromium:1023739,chromium:992974,chromium:1018879,chromium:None Change-Id: I9403d7a6b3187c2bea8cd9223c17811089c955b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914862Reviewed-by:
-
Shimi Zhang authored
According to ProxyBypassRules's doc, it will allow origins such as 127.0.0.1, [::1] etc by default. We should call AddRulesToSubtractImplicit() before adding any other rules to avoid implicitly allowing these origins. Bug: 1024614 Test: added a new test for it, it will fail without this fix. Change-Id: I32e56483bf37798ebf6cd49b244d20fa34d38157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914905Reviewed-by:
-
Austin Eng authored
These tests were removed due to a crash which has now been fixed. Bug: dawn:254 Change-Id: Ibd325bf29ee40951303dfb82832c0fea7f17a420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913461Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#715135}
-
Jeevan Shikaram authored
This CL prevents the installation of: - Youtube - Calendar - Google Photos - Google Maps - Gmail default apps for devices that have the tablet form factor turned on. Bug: 1013730 Change-Id: I8828a460050b1d0c7fcd8c423ed8d88d337d8a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903176Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
Improve WebAppSyncBridge::UpdateSync to use both current_state (before commit) and new_state (to be commit). In the future, it will help to skip local updates which don't touch sync data. Add WebAppSyncBridge::CommitUpdate unit tests (a.k.a. Local Changes). These tests is a promised follow up for this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1830494 This code is disabled by default behind kDesktopPWAsWithoutExtensions and kDesktopPWAsUSS base features. Bug: 860583 Change-Id: I51dfda8b6364e15f9b5eb398321d6010241b0ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914005Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#715133}
-
Nate Fischer authored
This configures AwMetricsServiceClient to "wake up" the MetricsService the same way Chrome's client does. This listens to the content-layer events for page load start/stop, renderer hangs, and closed renderer processes. This also adds an integration test to verify this works as expected (for the page load start case), and adds plumbing to configure the upload interval in the test (because the commandline switch is rate-limited to a 20 second minimum to avoid DOS'ing the server). Bug: 1003204 Test: run_webview_instrumentation_test_apk -f AwMetricsIntegrationTest.* Test: Manual - verify renderer hang case by using the AndroidX demo app Test: (which supports triggering and recovering from renderer hangs) Change-Id: I1f19f89cbc3625d4911755a2b17dd82908c2bb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900613 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Karan Bhatia authored
This CL moves some logic from ExtensionUrlPatternIndexMatcher to its base class, the RulesetMatcherInterface. In a subsequent CL, this common logic will also be used by RegexRulesMatcher, which will evaluate regex rules. This CL is split off of https://chromium-review.googlesource.com/c/chromium/src/+/1892132 for ease of review. It has no behavior change. BUG=974391 Change-Id: I2073ed480e5f15611ce2ba4eb1ea29cf7de7f0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910875 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#715131}
-
