• Sreeja Kamishetty's avatar
    Revert "Search Prefetch Streaming requests can be cancelled after headers" · e126c0c6
    Sreeja Kamishetty authored
    This reverts commit 583f52a3.
    
    Reason for revert:
    Following browser_tests failing on Linux MSAN bot
    
    All/SearchPrefetchServiceEnabledBrowserTest.OmniboxNavigateToMatchingEntryStreaming/1
    All/SearchPrefetchServiceEnabledBrowserTest.OmniboxNavigateToNonMatchingEntryStreamingCancels/1
    
    More details: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/26573/overview
    
    Original change's description:
    > Search Prefetch Streaming requests can be cancelled after headers
    >
    > The goal of this CL is to allow unneeded requests to be cancelled
    > when they are unlikely to be navigated to. This is achieved through
    > a few avenues of change:
    >
    > -- When the user navigates to something in omnibox, the URL is reported
    > to Search Prefetch Service to be able to mark it as likely to be served
    > (using kCanBeServedAndUserClicked when the request is kCanBeServed).
    > This occurs before the omnibox is closed and all results are wiped.
    > -- kCanBeServed are wiped when omnibox closes.
    > -- Streaming requests will no longer pause the mojo channel, so they can
    > witness the Complete event to be able to make the request as complete.
    > -- As part of above, we store the response body in memory instead of
    > just handing off the data pipe. Data pipes have a 500k data limit, which
    > search requests typically go over. Net won't send the complete event
    > until all data is in the pipe. Therefore we store the data and create a
    > pipe to navigation if needed.
    > -- Full body implementation now reports kComplete where it used to
    > report kCanBeServed.
    >
    > Bug: 1156325
    > Change-Id: Ied70a3eafd896801e263f631cb4d80556e762180
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583112
    > Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    > Reviewed-by: Robert Ogden <robertogden@chromium.org>
    > Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#835897}
    
    TBR=tbansal@chromium.org,robertogden@chromium.org,ryansturm@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
    
    Change-Id: I130213d5d9d72641b12be31192f51461957cd15b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1156325
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584426Reviewed-by: default avatarSreeja Kamishetty <sreejakshetty@chromium.org>
    Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#836038}
    e126c0c6
search_prefetch_service.h 3.08 KB