• Hiroki Nakagawa's avatar
    Revert "Initialize the WRL::Module only once." · e7745ead
    Hiroki Nakagawa authored
    This reverts commit e69195e1.
    
    Reason for revert:
    This is a speculative revert. updater_tests has been failing on Win7
    Tests (dbg) since the CL range containing this change:
    https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/85110
    
    Original change's description:
    > Initialize the WRL::Module only once.
    > 
    > The issue with the crashing code is that on the RPC client side
    > of the updater, both update and control services must be instantiated.
    > They both called WRL::Module::Create, which caused WRL code to assert.
    > 
    > The server side of RPC also initializes the module, in a slightly
    > different way. Therefore, module initialization in the App base
    > class is not practical. It has to be done in a way specific to
    > the client, or the server, or the mode App is instantiated as.
    > 
    > Using a leaky singleton is not great. However, there is singleton
    > already in the WRL::Module, so a leaking singleton in the updater
    > just shows that fact.
    > 
    > Bug: 1128748
    > Change-Id: I646c5ef779c4affe7f2fe8f751d1dea1f16f8608
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414847
    > Reviewed-by: S. Ganesh <ganesh@chromium.org>
    > Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    > Commit-Queue: Sorin Jianu <sorin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#807682}
    
    TBR=ganesh@chromium.org,sorin@chromium.org,waffles@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1128748
    Change-Id: I63884d9bc165130c7eaab196520eb4583c87970d
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426149Reviewed-by: default avatarHiroki Nakagawa <nhiroki@chromium.org>
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#810030}
    e7745ead
control_service_out_of_process.h 1.54 KB