GitLab

The sync datatype is the last leftover that hasn't been wrapped in the
USS architecture, and could end up in the critical path to future
dismantling efforts.

The new controller has been simplified by instead introducing the
notion of model-readiness in SyncableService, which the USS codepath
honors. This makes the new controller a lot simpler, and is aligned
with our plans to avoid the notion of model readiness in controllers,
and narrow down the scope of DataTypeController::ReadyForStart() to
non-transient business logic (i.e. is a datatype allowed to start).

Sync integration tests are now parameterized to exercise both codepaths
in case the feature toggle must be used in the future as kill switch.

Bug: 870624,939329
Change-Id: I9d415eba7bd53f0fd9cf7bbfa00db98b7e916e1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507657Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638630}