GitLab

The sync datatype is the last leftover that hasn't been wrapped in the
USS architecture, and could end up in the critical path to future
dismantling efforts.

The new controller has been simplified by instead introducing the
notion of model-readiness in SyncableService, which the USS codepath
honors. This makes the new controller a lot simpler, and is aligned
with our plans to avoid the notion of model readiness in controllers,
and narrow down the scope of DataTypeController::ReadyForStart() to
non-transient business logic (i.e. is a datatype allowed to start).

Sync integration tests are now parameterized to exercise both codepaths
in case the feature toggle must be used in the future as kill switch.

Bug: 870624,939329
Change-Id: I9d415eba7bd53f0fd9cf7bbfa00db98b7e916e1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507657Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638630}

UpdateScoreDict is causing a crash when we are getting
keys and this could be caused by old data that does
not have all the keys. This hardens the checks when
loading the data.

BUG=934165

Change-Id: I35eafc9b2a232ff8cc79fd48b48de9cc09cfc65d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508596Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638629}

This is the platform independent version of the notification trigger
which simply starts a timer. This requires Chrome to be running at the
time the notification should be displayed. If Chrome is not running, the
notification will be shown at the next startup.

A follow-up CL will override this behaviour for Android and use the
BackgroundTaskScheduler to wake up Chrome.

Bug: 891339
Change-Id: I679df47d725371aa481c30bcaa742f4760106e9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1477840
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638628}

Change client code to work as if IdentityManager::GetPrimaryAccount
where returning a CoreAccountInfo instead of an AccountInfo. Method
will be updated in a followup CL.

This CL was uploaded by git cl split.

Bug: 926204
Change-Id: Ic7e29b114fd39ee0c55cafb1a0e526eb1aa78244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499559Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638627}

When the input caret position is "AfterCharacter", the function should
look backwards for the result position in DOM. Hence, it should call
GetFirstPosition() instead of GetLastPosition().

Bug: 894651
Change-Id: If2c9e8346c38859d0b8674dd56f49fbc71aa3ccc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506768Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638626}

This patch is largely removing the use of 'suggestion' from a
generic MVC class.

Change-Id: I20e5932d0638da0489ed002ffa8555874bd10eba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506206Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638625}

This change adds accessibility content description for refine button

Bug: 939014
Change-Id: Ief2f5d1e5aa14498d03eda7827788dfd0d752ea6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506557
Commit-Queue: Ender <ender@google.com>
Auto-Submit: Ender <ender@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638624}

Needs https://android-review.googlesource.com/c/platform/external/perfetto/+/910574
to land and roll into Chrome before this can land.

R=ssid@chromium.org

Bug: 839084
Change-Id: I945eca9387c562a144af30dfee9f7759a23e3f49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500134
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638623}

There are two icon properties, kAppIcon and kWindowIcon. For the
purposes of Ash, these are used interchangeably (kAppIcon is preferred
and kWindowIcon is a fallback). Thus we can skip sending kWindowIcon.
This should cut down on memory usage by half.

Further, the only place that the icon is used for single process
mash is in overview mode, which displays the icon at 24dip. We can
downscale the icon before sending it over. For tabbed browser windows,
that's 24dip*24dip instead of 192px * 192px.

Since the icons are set on the content window as well as the root
window, they are each copied to the window service twice. We do need
to transport the icons that are set on the root window, but not on
the content window. PropertyConverter doesn't distinguish on the window
type, so new keys are introduced for the root window: kAppIconSmallKey
and kAppIconLargeKey. These are the only ones that are sent to the WS.
They are only used in Mash. kAppIconKey and kWindowIconKey are retained
for use in the browser, e.g. by AppWindowLauncherItemController.
kAppIconLargeKey is only set by the task manager and used by
ShelfWindowWatcher for the shelf icon.

The net effect is that every browser window goes from allocating
192x192px four times, to 24x24dip once. According to chrome://tracing
this lops about 4MiB off malloc'd memory in the browser process when
there are 10 browser windows open.

Bug: 938105

Change-Id: I7bc04784ff3fb1d0857219eae2184542b1f14fd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504164Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638622}

- New profile avatar icons are added to Chrome.
- The avatar selector is refreshed:
  - Only the new avatars are available for selection.
  - The icons are made round and bigger.
- Existing profiles will keep their current avatars, i.e.
  they don't need to be migrated.

Screenshots:
https://drive.google.com/file/d/1m5tDHR9k-2Z9ZkQfza-l7D3oZIsTgftu/view?usp=sharing
https://drive.google.com/file/d/11lzTzZJR_qBT4qziY_Z5lbgPgyrBHVBa/view?usp=sharing

Bug: 937834
Change-Id: Iffe141de2aa9d176690cc1caaed05afd76adccff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505942Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638621}

Bug: 937007
Change-Id: Ibe088bf8b76446098520284a50ac84ec5140ce0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495801
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638620}

Before this change, we do not capture mouse events to widget when
set/release pointer capture. It causes a bug that when mouse down on
main frame and set pointer capture, mouse still not capture to the main
frame widget because we neither set widget capture on main frame mouse
down nor set widget capture on pointer capture set.

This CL makes PEM::SetPointerCapture and ReleasePointerCapture returns
a boolean to shows whether pointer capture is changed, and we change
widget capture accordingly.

Change-Id: I1d571659237c81f8575d4556d725c22c8c2b862f
Bug: 936190, 919908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1446500
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638619}

We recently introduced a new AXMode that turns on image
labeling for a WebContents, and it's integrated into
BrowserAccessibilityState, the mechanism used to
set the global AXMode on most platforms.

On Chrome OS the mechanism is slightly different, using
the automation API, and we missed one place. Fix it
by merging the AXMode set for the automation API with
the image labeling flag if needed, and add a test for it.

Bug: 938637, 905419

Change-Id: I273b35e3ef2457207f8a5ff4482cfeae4178027d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504695
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638618}

Before this patch, if PaymentRequest.show() was called in a CCT, then
user opened the CCT page in Chrome, and a skip-UI payment app was slow
to respond to the `canmakepayment` event, then the activity to which
Chrome attached the payment UI would be gone by the time the payment UI
needs to be shown, which would cause a crash. The skip-UI bit is
important, because in this flow Chrome blocks UI interactions only after
launching the payment app (after the response to `canmakepayment`
event).

This patch waits to attach the payment UI to the current Chrome activity
via buildUI(chromeActivity) until immediately before blocking UI
interactions via mUI.show() or mUI.dimBackground().

After this patch, Chrome does not crash when PaymentRequest.show() was
called in a CCT for skip-UI flow and the user opened the CCT page in
Chrome before the payment app responded to the `canmakepayment` event.

Bug: 817073
Change-Id: I5ce50d000c2f64a60c62955d9e3e8f080498238d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506494
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638617}

This patch fixes disposition/misplacement of menu windows and let the
Wayland compositor decide how to place the windows if their pixels
cannot be shown on one display or if they are partly going to be hidden
because of being shown too close to some edges of a display.

First of all, Chromium positions windows using screen coordinates.
As long as Wayland does not provide global coordinates, the client
does not know the position of windows in screen coordinates and
always assumes that they are located on 0,0. What's left for us to do
is to translate bounds from screen coordinates to relative to parent
coordinates, which is easy to do.

Secondly, WaylandWindow re-positions nested menus back to the right side
of parent menus (if the size of a top level window is close or equal to the
work area of a display) and let Wayland compositor decide how to position
them based on calculated anchor rect, anchor and gravity. The exception
for this is based on the maximized state of a top level window.
If it's maximized, then the nested windows are not re positioned
and left on the left side of the parent menu windows.

Also, WaylandWindow must be able to recalculate origin back from
relative to parent to be relative to top level window aka on screen
location.

The unittests exercises all those mentioned cases and make sure
WaylandWindow is able to calculated bounds correctly (the values
are taken by manual usage of the Chromium browser and logs).

PS XdgVersionV5Test/WaylandWindowTest.AdjustPopupBounds/0 is skipped
as long as it does not support xdg positioner.

Test: XdgVersionV6Test/WaylandWindowTest.AdjustPopupBounds/0
Bug: 927280
Change-Id: I30573620562e7bc5dfd3a69487326bcda49fc6ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474654Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#638616}

Before sending over to be logged by DevTools, filter out DOM nodes that
have a type attribute equal to "password", and that are not empty.

Bug: 934609
Change-Id: I147ad0c2bad13cc50394f4b5ff2f4bfb7293114b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506498
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638615}

Bug: 939160
Change-Id: I9371553975c56bb19450aed1ac12296708c0e412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507233Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638614}

Change-Id: Ide05b93e62e29bcf34e813022b1214f37af1c0be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498783Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638613}

Bug: 939148
Change-Id: If82c99bfdf0834589a818591502928212ad35e34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508694
Commit-Queue: Sam Maier <smaier@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638612}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5b257f91fc81..fff41430adb0


Created with:
  gclient setdep -r src-internal@fff41430adb0

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org

Change-Id: Iff68f0840621d962d57111f3518f089c10c3b932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508832Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638611}

https://android.googlesource.com/platform/external/perfetto.git/+log/c0eace27e740..2d4d2a3cf7b9


git log c0eace27e740..2d4d2a3cf7b9 --date=short --no-merges --format='%ad %ae %s'
2019-03-07 treehugger-gerrit@google.com Merge "Fix build."


Created with:
  gclient setdep -r src/third_party/perfetto@2d4d2a3cf7b9

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I8fa07e1ec24322b3e41158eedc19af82f3ad01ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508554Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638610}

Bug 933878 is phasing out the use of AsyncFileSystemCallbacks in
favor of concrete callback classes.

This CL is a follow up of [1] replaces a left over usage and removes
a unneeded include.

[1] crrev.com/c/1499873

R=jbroman@chromium.org
CC=​​blink-reviews-vendor@chromium.org

BUG=933878

Change-Id: Ia46cdc035da04c9c2c8d9c968d9d0163320b0c59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508612
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#638609}

Bug: 939191

Change-Id: I0fecec51bb541e3557790b2502df15346d0c5f61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507275Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638608}

* Make tryToSetTopLevelFrame() and tryToClearTopLevelFrame() to return
void instead. Nobody was using the returned value anyway.
* Remove topLoadingFrame(). I was not used externally.

No behavior changes here.

Bug: 936696
Change-Id: I21c4266140dba897a89f4ae558c2a30dbb44615b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492339
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638607}

Through Finch configuration, the add to homescreen banner can now have
one of three values (the first being the default option):

  - Add <site> to Home screen
  - Install <site>
  - Install <site> (no download required)

Bug: 937871
Change-Id: Ie519d5e80f345c9ebdfff490659632f8842bddf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499566
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638606}

It will be used by the test engine later on to convert goldens to and from
the processor-specific structures.

Bug: 935711
Change-Id: I84d2ea9f8eb742b1d7f1a062eeea88dfb7f30d23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492091
Commit-Queue: G. Silva <gfaus@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638605}

Bug: 938974
Change-Id: I9fa64579b8dcaf5e0434383c6068ff83a607ef65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506393
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638604}

This CL switches DownloadMediaParserTest from using
BaseJUnit4ClassRunner to using ChromeJUnit4ClassRunner.
because ChromeJUnit4ClassRunner knows about
UiRestriction.RESTRICTION_TYPE_PHONE

BUG=939218

Change-Id: Iea95b4c088d9447664e569d1cee616b2c4d89038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507396Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638603}

Change client code to work as if IdentityManager::GetPrimaryAccount
where returning a CoreAccountInfo instead of an AccountInfo. Method
will be updated in a followup CL.

This CL was uploaded by git cl split.

Bug: 926204
Change-Id: I7ed54720bb93c83df6802f83034138f71bb8e479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499515
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638602}

- Fix DCHECK: is_running_xxx_animation_on_compositor should not be set
  in non-BGPT mode. The DCHECK is to check if the flag is set, we must
  have CompositingReason::kActiveXXXAnimation in
  direct_compositing_reasons (which is not set in non-BGPT).

- Add virtual/disable-blink-gen-property-trees/animations to avoid
  regressions in non-BGPT mode when we make animation changes.
  The virtual suite is run with --enable-threaded-compositing which is
  closer to real world.

Bug: 836884
Change-Id: I2f88db3423a9938cb55ce91244735b3881d31a7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507044
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638601}

This change disallows tab-switching unless the experiment
AutofillAssistantChromeEntry is enabled, as Autofill Assistant normally
doesn't need it.

Before this change, it was possible to take Autofill Assistant out of
the Chrome Custom tab by choosing "Open in Chrome". It was possible to
have more than one tab open on Chrome Custom Tab without breaking
Autofill Assistant.

With this change, Autofill Assistant turns itself off when choosing
"Open in Chrome" and enters an error when a new tab is opened in Chrome
Custom Tab, like M73 does.

Bug: 925947, b/125738726
Change-Id: I39fc8aecf4479183d6c115c775b13bb218590f57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507658
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#638600}

Change-Id: Ibc22fe9f59e7a5cd79b2e4a3a3de08f445c15812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489179
Auto-Submit: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638599}

CompositorOverlayCandidateValidatorOzone took a string that was really a
comma separated list of overlay strategies. The string was parsed into a
list of callbacks that were later used to create the appropriate
strategy objects.

This CL changes CompositorOverlayCandidateValidatorOzone to take a list
of OverlayStrategy enums instead. The enum already existed for UMA and
it contains an entry for each overlay strategy. Use the list of enum
values to directly instantiate the strategy objects, saving a layer
indirection.

Move the enum to //components/viz/common so it can be used with IPC
later. Also move the code to parse a string containing a comma separated
list of strategies, as this is used by the --enable-hardware-overlays
flag.

Bug: 930173
Change-Id: Ie5d6d501e3117cf4be0fcf29ac8bdf29744041da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505839Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638598}

Bug: 923083
Change-Id: I62679448e96ea016d73b2e7c4d955b3a514d2be6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496312
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Brian White <bcwhite@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638597}

This reverts commit d17a7e3c.

Reason for revert: Increase in heap corruption (and other?) crashes
in the d3dcompiler code path, such as  crbug.com/932359. We have run
out of time to investigate before branching.

Original change's description:
> Switch to full 17763 SDK, including new d3dcompiler_47.dll
>
> The new (10.0.17763.0) version of d3dcompiler_47.dll contains various
> bug fixes which we want to ship. We initially avoided upgrading it with
> the rest of the SDK because it depends on the universal Windows 10 CRT
> (UCRT) which some Windows 7 machines lack. This caused test failures on
> some bots and would cause failures on some customer machines.
>
> This change updates how we package isolates so that they always include
> the UCRT, to avoid test failures. It also ships api-ms-win-*.dll and
> ucrtbase*.dll in mini_installer.exe so that the UCRT will be shipped to
> customers. The size increase to mini_installer.exe for this is about
> 400,000 bytes.
>
> This change also deletes an unused function (_read_configuration_from_gn)
> from create_installer_archive.py that sent me down an incorrect path
> while investigating fixes.
>
> The toolchain package is the same as the one used when landing
> crrev.com/c/1401403 except that the 17763 version of d3dcompiler_47.dll
> was retained. See that CL for full instructions on creating the
> toolchain package.
>
> Bug: 920704
> Change-Id: I9cb7a7ed5cb75d04962fc64869d26b12617c0463
> Reviewed-on: https://chromium-review.googlesource.com/c/1450414
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#629193}

TBR=brucedawson@chromium.org,grt@chromium.org

Bug: 920704
Change-Id: Ia986017541e5e80a3cc5f1d96494e0e12a841ed1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507040Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638596}

This change removes the sound-content-setting flag, the backing
SoundContentSetting feature, and all logic referencing it.

Bug: 896400
Change-Id: I80344ade50309df7c667d86477801106adfd3768
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503619Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638595}

Our NG TextIterator didn't implement the EmitsSpaceForNbsp behavior.
This patch implements it.

Change-Id: I76e7531ee013494566c15417658042b012462690
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506972
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638594}

Replace deprecatiod Date::DateTimeConfigurationChangeNotification
function with Isolate::DateTimeConfigurationChangeNotification.

Bug: v8:8834
Change-Id: Iba2008d017d66d2ab27f952fe04b98597c2f86dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507873
Auto-Submit: Dan Elphick <delphick@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638593}

Rather than using ObjectTemplateBuilder::SetProperty() on GinPort, use
ObjectTemplateBuilder::SetLazyDataProperty(). This allows author script
to reset the properties to be something else, which is more inline with
the majority of JS objects exposed to scripts.

Add tests for the same.

Bug: 927887
Change-Id: I8f983918014d69941992423eece5fd1eed9c58e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506771Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638592}

Bug: 936989
Change-Id: I283cbb9f87e912c8094872a70c6abc193659cbe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497198Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Daniel McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638591}