• Bao-Duy Tran's avatar
    metrics: Mark InputMethodID enum as obsolete and remove its entries. · f314a5d3
    Bao-Duy Tran authored
    This enum is only applicable to obsolete InputMethod.ID histogram that's
    been deprecated since M46. Therefore it should have been marked obsolete
    together with the histogram's deprecation 6 years ago (July 2014, see
    https://crrev.com/254e75d880369bf49bdf0e8ccc400ab71f6f2fee).
    
    The enum ID needs to be marked obsolete (and not removed), as per UMA
    guidelines to avoid inadvertent reuse that causes confusion in future.
    Enum etries can however be completely cleaned up, because InputMethod.ID
    was a sparse histogram (not an enum histogram) and these reverse
    mappings from numerical values to labels aren't exhaustive anyway.
    These removals are akin to adjusting the labels to 'unknown'.
    
    These removals only make interpretation of old data inconvenient. It's
    however unlikely we'd need to analyse data of deprecated InputMethod.ID
    metric that's no longer been recorded for the past 6 years. In the
    highly unlikely event we need to do so, repo history is at our disposal.
    
    Bug: 1150183
    Change-Id: I3f274c038be1b334a4e49ccbef3bae518ede0019
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546345Reviewed-by: default avatarDarren Shen <shend@chromium.org>
    Reviewed-by: default avatarJing Wang <jiwan@chromium.org>
    Reviewed-by: default avatarJesse Doherty <jwd@chromium.org>
    Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#829569}
    f314a5d3
enums.xml 3.39 MB
The source could not be displayed because it is larger than 1 MB. You can load it anyway or download it instead.