Skip to content

GitLab

T
tangled
Commit f314a5d3 authored by Bao-Duy Tran's avatar Bao-Duy Tran Committed by Commit Bot
Browse files
Options

metrics: Mark InputMethodID enum as obsolete and remove its entries. 

This enum is only applicable to obsolete InputMethod.ID histogram that's
been deprecated since M46. Therefore it should have been marked obsolete
together with the histogram's deprecation 6 years ago (July 2014, see
https://crrev.com/254e75d880369bf49bdf0e8ccc400ab71f6f2fee).

The enum ID needs to be marked obsolete (and not removed), as per UMA
guidelines to avoid inadvertent reuse that causes confusion in future.
Enum etries can however be completely cleaned up, because InputMethod.ID
was a sparse histogram (not an enum histogram) and these reverse
mappings from numerical values to labels aren't exhaustive anyway.
These removals are akin to adjusting the labels to 'unknown'.

These removals only make interpretation of old data inconvenient. It's
however unlikely we'd need to analyse data of deprecated InputMethod.ID
metric that's no longer been recorded for the past 6 years. In the
highly unlikely event we need to do so, repo history is at our disposal.

Bug: 1150183
Change-Id: I3f274c038be1b334a4e49ccbef3bae518ede0019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546345Reviewed-by: default avatarDarren Shen <shend@chromium.org>
Reviewed-by: default avatarJing Wang <jiwan@chromium.org>
Reviewed-by: default avatarJesse Doherty <jwd@chromium.org>
Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829569}
parent 2aaa17f4
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 154 deletions
tools/metrics/histograms/enums.xml
View file @ f314a5d3
...@@ -37864,160 +37864,9 @@ Called by update_gpu_driver_bug_workaround_entries.py.--> ...@@ -37864,160 +37864,9 @@ Called by update_gpu_driver_bug_workaround_entries.py.-->
</enum> </enum>
<enum name="InputMethodID"> <enum name="InputMethodID">
<int value="109700" label="xkb:am:phonetic:arm"> <obsolete>
Armenian Phonetic keyboard Only applicable to InputMethod.ID histogram that was deprecated at M46.
</int> </obsolete>
<int value="109800" label="xkb:be::fra">Belgian keyboard</int>
<int value="109801" label="xkb:be::ger">Belgian keyboard</int>
<int value="109802" label="xkb:be::nld">Belgian keyboard</int>
<int value="109803" label="xkb:bg::bul">Bulgarian keyboard</int>
<int value="109804" label="xkb:bg:phonetic:bul">
Bulgarian Phonetic keyboard
</int>
<int value="109805" label="xkb:br::por">Brazilian keyboard</int>
<int value="109806" label="xkb:by::bel">Belarusian keyboard</int>
<int value="109900" label="xkb:ca::fra">Canadian French keyboard</int>
<int value="109901" label="xkb:ca:eng:eng">Canadian English keyboard</int>
<int value="109902" label="xkb:ca:multix:fra">
Canadian Multilingual keyboard
</int>
<int value="109903" label="xkb:ch::ger">Swiss keyboard</int>
<int value="109904" label="xkb:ch:fr:fra">Swiss French keyboard</int>
<int value="109905" label="xkb:cz::cze">Czech keyboard</int>
<int value="109906" label="xkb:cz:qwerty:cze">Czech QWERTY keyboard</int>
<int value="110000" label="xkb:de::ger">German keyboard</int>
<int value="110001" label="xkb:de:neo:ger">German NEO 2 keyboard</int>
<int value="110002" label="xkb:dk::dan">Danish keyboard</int>
<int value="110100" label="xkb:ee::est">Estonian keyboard</int>
<int value="110101" label="xkb:es::spa">Spanish keyboard</int>
<int value="110102" label="xkb:es:cat:cat">Catalan keyboard</int>
<int value="110200" label="xkb:fi::fin">Finnish keyboard</int>
<int value="110201" label="xkb:fr::fra">French keyboard</int>
<int value="110300" label="xkb:gb:dvorak:eng">UK Dvorak keyboard</int>
<int value="110301" label="xkb:gb:extd:eng">UK keyboard</int>
<int value="110302" label="xkb:ge::geo">Georgian keyboard</int>
<int value="110303" label="xkb:gr::gre">Greek keyboard</int>
<int value="110400" label="xkb:hr::scr">Croatian keyboard</int>
<int value="110401" label="xkb:hu::hun">Hungarian keyboard</int>
<int value="110500" label="xkb:ie::ga">Irish keyboard</int>
<int value="110501" label="xkb:il::heb">Hebrew keyboard</int>
<int value="110502" label="xkb:is::ice">Icelandic keyboard</int>
<int value="110503" label="xkb:it::ita">Italian keyboard</int>
<int value="110600" label="xkb:jp::jpn">Japanese keyboard</int>
<int value="110800" label="xkb:latam::spa">Latin American keyboard</int>
<int value="110801" label="xkb:lt::lit">Lithuanian keyboard</int>
<int value="110802" label="xkb:lv:apostrophe:lav">Latvian keyboard</int>
<int value="110900" label="xkb:mn::mon">Mongolian keyboard</int>
<int value="111000" label="xkb:no::nob">Norwegian keyboard</int>
<int value="111200" label="xkb:pl::pol">Polish keyboard</int>
<int value="111201" label="xkb:pt::por">Portuguese keyboard</int>
<int value="111400" label="xkb:ro::rum">Romanian keyboard</int>
<int value="111401" label="xkb:ro:std:rum">Romanian Standard keyboard</int>
<int value="111402" label="xkb:rs::srp">Serbian keyboard</int>
<int value="111403" label="xkb:ru::rus">Russian keyboard</int>
<int value="111404" label="xkb:ru:phonetic:rus">
Russian Phonetic keyboard
</int>
<int value="111500" label="xkb:se::swe">Swedish keyboard</int>
<int value="111501" label="xkb:si::slv">Slovenian keyboard</int>
<int value="111502" label="xkb:sk::slo">Slovakian keyboard</int>
<int value="111600" label="xkb:tr::tur">Turkish keyboard</int>
<int value="111700" label="xkb:ua::ukr">Ukrainian keyboard</int>
<int value="111701" label="xkb:us::eng">US keyboard</int>
<int value="111702" label="xkb:us::fil">US keyboard</int>
<int value="111703" label="xkb:us::ind">US keyboard</int>
<int value="111704" label="xkb:us::msa">US keyboard</int>
<int value="111705" label="xkb:us:altgr-intl:eng">US Extended keyboard</int>
<int value="111706" label="xkb:us:colemak:eng">US Colemak keyboard</int>
<int value="111707" label="xkb:us:dvorak:eng">US Dvorak keyboard</int>
<int value="111708" label="xkb:us:intl:eng">US International keyboard</int>
<int value="111709" label="xkb:us:intl:nld">US International keyboard</int>
<int value="111710" label="xkb:us:intl:por">US International keyboard</int>
<int value="209700" label="zh-hant-t-i0-array-1992">Array input method</int>
<int value="209900" label="zh-hant-t-i0-cangjie-1987">
Cangjie input method
</int>
<int value="209901" label="zh-hant-t-i0-cangjie-1987-x-m0-simplified">
Quick input method
</int>
<int value="210000" label="zh-hant-t-i0-dayi-1988">Dayi input method</int>
<int value="211200" label="zh-hant-t-i0-pinyin">
Traditional Pinyin input method
</int>
<int value="211201" label="zh-t-i0-pinyin">Pinyin input method</int>
<int value="211700" label="zh-hant-t-i0-und">Zhuyin input method</int>
<int value="211900" label="zh-t-i0-wubi-1986">Wubi input method</int>
<int value="310600" label="nacl_mozc_jp">
Google Japanese Input (for Japanese keyboard)
</int>
<int value="311700" label="nacl_mozc_us">
Google Japanese Input (for US keyboard)
</int>
<int value="405000" label="hangul_2set">Hangul 2 Set</int>
<int value="405100" label="hangul_3set390">Hangul 3 Set (390)</int>
<int value="405101" label="hangul_3setfinal">Hangul 3 Set (Final)</int>
<int value="405102" label="hangul_3setnoshift">Hangul 3 Set (No Shift)</int>
<int value="409700" label="hangul_ahnmatae">Hangul Ahnmatae</int>
<int value="411400" label="hangul_romaja">Hangul Romaja</int>
<int value="509700" label="vkd_ar">Arabic keyboard</int>
<int value="509800" label="vkd_bn_phone">Bengali keyboard (Phonetic)</int>
<int value="509900" label="vkd_ckb_ar">
Sorani Kurdish Arabic-based keyboard
</int>
<int value="509901" label="vkd_ckb_en">
Sorani Kurdish English-based keyboard
</int>
<int value="510000" label="vkd_deva_phone">
Devanagari keyboard (Phonetic)
</int>
<int value="510100" label="vkd_ethi">Ethiopic keyboard</int>
<int value="510200" label="vkd_fa">Persian keyboard</int>
<int value="510300" label="vkd_gu_phone">Gujarati keyboard (Phonetic)</int>
<int value="510700" label="vkd_km">Khmer keyboard</int>
<int value="510701" label="vkd_kn_phone">Kannada keyboard (Phonetic)</int>
<int value="510800" label="vkd_lo">Lao keyboard</int>
<int value="510900" label="vkd_ml_phone">Malayalam keyboard (Phonetic)</int>
<int value="510901" label="vkd_my">Myanmar keyboard</int>
<int value="510902" label="vkd_my_myansan">Myanmar Myansan keyboard</int>
<int value="511000" label="vkd_ne_inscript">Nepali keyboard (InScript)</int>
<int value="511001" label="vkd_ne_phone">Nepali keyboard (Phonetic)</int>
<int value="511500" label="vkd_si">Sinhala keyboard</int>
<int value="511600" label="vkd_ta_inscript">Tamil keyboard (InScript)</int>
<int value="511601" label="vkd_ta_itrans">Tamil keyboard (itrans)</int>
<int value="511602" label="vkd_ta_phone">Tamil keyboard (Phonetic)</int>
<int value="511603" label="vkd_ta_tamil99">Tamil keyboard (Tamil99)</int>
<int value="511604" label="vkd_ta_typewriter">
Tamil keyboard (Typewriter)
</int>
<int value="511605" label="vkd_te_phone">Telugu keyboard (Phonetic)</int>
<int value="511606" label="vkd_th">Thai keyboard (Kedmanee)</int>
<int value="511607" label="vkd_th_pattajoti">Thai keyboard (Pattachote)</int>
<int value="511608" label="vkd_th_tis">Thai keyboard (TIS 820-2531)</int>
<int value="511800" label="vkd_vi_tcvn">Vietnamese keyboard (TCVN)</int>
<int value="511801" label="vkd_vi_telex">Vietnamese keyboard (Telex)</int>
<int value="511802" label="vkd_vi_viqr">Vietnamese keyboard (VIQR)</int>
<int value="511803" label="vkd_vi_vni">Vietnamese keyboard (VNI)</int>
<int value="609700" label="am-t-i0-und">Transliteration Amharic</int>
<int value="609701" label="ar-t-i0-und">Transliteration Arabic</int>
<int value="609800" label="bn-t-i0-und">Transliteration Bengali</int>
<int value="609801" label="braille">Braille Keyboard</int>
<int value="610100" label="el-t-i0-und">Transliteration Greek</int>
<int value="610200" label="fa-t-i0-und">Transliteration Persian</int>
<int value="610300" label="gu-t-i0-und">Transliteration Gujarati</int>
<int value="610400" label="he-t-i0-und">Transliteration Hebrew</int>
<int value="610401" label="hi-t-i0-und">Transliteration Hindi</int>
<int value="610700" label="kn-t-i0-und">Transliteration Kannada</int>
<int value="610900" label="ml-t-i0-und">Transliteration Malayalam</int>
<int value="610901" label="mr-t-i0-und">Transliteration Marathi</int>
<int value="611000" label="ne-t-i0-und">Transliteration Nepali</int>
<int value="611100" label="or-t-i0-und">Transliteration Oriya</int>
<int value="611200" label="pa-t-i0-und">Transliteration Punjabi</int>
<int value="611500" label="sa-t-i0-und">Transliteration Sanskrit</int>
<int value="611501" label="sr-t-i0-und">Transliteration Serbian</int>
<int value="611600" label="ta-t-i0-und">Transliteration Tamil</int>
<int value="611601" label="te-t-i0-und">Transliteration Telugu</int>
<int value="611602" label="ti-t-i0-und">Transliteration Tigrinya</int>
<int value="611700" label="ur-t-i0-und">Transliteration Urdu</int>
</enum> </enum>
<enum name="InputMethodID2"> <enum name="InputMethodID2">
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment