• Mike West's avatar
    Revert "[MediaRouter] Add warning for invalid permissions" · f39703db
    Mike West authored
    This reverts commit b5bdc990.
    
    Reason for revert: 
    `MediaRouterViewsUITest.RouteCreationTimeoutForDesktop` started failing after this CL in https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/2446?blamelist=1#blamelist-tab. The error message in the related test is https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874579294717582880/+/steps/unit_tests_on_Mac-10.15/0/logs/Deterministic_failure:_MediaRouterViewsUITest.RouteCreationTimeoutForDesktop__status_CRASH_/0:
    
    ```
    Actual function call count doesn't match EXPECT_CALL(*mock_router_, CreateRouteInternal( _, _, _, _, _, base::TimeDelta::FromSeconds(timeout_seconds), false))...
             Expected: to be called once
               Actual: never called - unsatisfied and active
    Stack trace:
    0   unit_tests                          0x000000010fcfba8c testing::internal::GoogleTestFailureReporter::ReportFailure(testing::internal::FailureReporterInterface::FailureType, char const*, int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 92
    1   unit_tests                          0x000000010fcffc05 testing::internal::UntypedFunctionMockerBase::VerifyAndClearExpectationsLocked() + 597
    2   unit_tests                          0x000000010fd00521 testing::Mock::VerifyAndClearExpectationsLocked(void*) + 401
    3   unit_tests                          0x000000010fd00371 testing::Mock::VerifyAndClearExpectations(void*) + 33
    4   unit_tests                          0x000000010f26566b media_router::MediaRouterViewsUITest::StartCastingAndExpectTimeout(media_router::MediaCastMode, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) + 2491
    5   unit_tests                          0x000000010f2659a4 media_router::MediaRouterViewsUITest_RouteCreationTimeoutForDesktop_Test::TestBody() + 52
    
    Received signal 11 SEGV_MAPERR 000000000008
     [0x000114431eb9]
     [0x000114377dc3]
     [0x000114431dd1]
     [0x7fff70e295fd]
     [0x7fff70de9297]
     [0x00010f2659a4]
     [0x00010fd1860d]
     [0x00010fd193cf]
     [0x00010fd19d47]
     [0x00010fd283a7]
     [0x00010fd27e1f]
     [0x00011384b7fb]
     [0x0001138623b3]
     [0x00011386225f]
     [0x000113835f25]
     [0x7fff70c30cc9]
    [end of stack trace]
    ```
    
    Bug: 1106647
    
    
    Original change's description:
    > [MediaRouter] Add warning for invalid permissions
    > 
    > This patch adds a new check to the media router views UI that, on Mac OS
    > X 10.15+ (Catalina), checks if the screen capture permission has been
    > granted, and shows a warning message and fails to cast if so.
    > 
    > Bug: 1087236
    > Change-Id: I3afdfdb06a011fee3e6fd5f199d375d0ab6eef88
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298479
    > Commit-Queue: Jordan Bayles <jophba@chromium.org>
    > Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#789194}
    
    TBR=mfoltz@chromium.org,takumif@chromium.org,jophba@chromium.org
    
    Change-Id: I64651c90503bf90a2f9cfca99f7929efd35b4c23
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1087236
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302613Reviewed-by: default avatarMike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#789391}
    f39703db
media_router_strings.grdp 11.1 KB