• morrita's avatar
    Android: Get rid of extra dup()s on launching child processes · f7302eb7
    morrita authored
    This is a regression from [1] which added a dup() call on
    the renderer launching process. This CL removes these calls
    by reveiling the subtle ownership of the file descriptors.
    
    The original intention here was to completely hide and simplify
    the notion of the ownership, at the cost of a few dup() calls.
    However, the crash report on the reported bug indicates that
    the dup() can fail and it lets the renderer initialization fail,
    probably due to some per-process limit of the number of opened files.
    
    [1] https://codereview.chromium.org/585203002
    
    R=mdempsky@chromium.org, jam@chromium.org
    BUG=455364
    
    Review URL: https://codereview.chromium.org/909553003
    
    Cr-Commit-Position: refs/heads/master@{#315353}
    f7302eb7
file_descriptor_info_impl.h 1.43 KB