Skip to content

GitLab

T
tangled
Commit 06e25257 authored by Luna Lu's avatar Luna Lu Committed by Commit Bot
Browse files
Options

Revert "Position fixed backgrounds in table sections correctly" 

This reverts commit b4ee3ace.

Reason for revert: suspect breaking tables/mozilla_expected_failures/marvin/backgr_fixed-bg.html
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=tables%2Fmozilla_expected_failures%2Fmarvin%2Fbackgr_fixed-bg.html&testType=webkit_tests

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.9

The test has been consistently failing on Mac OS 10.9
 
Original change's description:
> Position fixed backgrounds in table sections correctly
> 
> Bug: 35697
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I1d50b8027f30ea775af91db62ad9de3f8f697c62
> Reviewed-on: https://chromium-review.googlesource.com/594987
> Commit-Queue: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491294}

TBR=wangxianzhu@chromium.org,robhogan@gmail.com,eae@chromium.org

Change-Id: Id2939cb178de44d6b601f353ca1acc8145802ced
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 35697
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/598407Reviewed-by: default avatarLuna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491394}
parent 881ef9aa
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 30 deletions
third_party/WebKit/LayoutTests/fast/table/backgr_fixed-bg-table-expected.txt deleted 100644 → 0
View file @ 881ef9aa
layer at (0,0) size 800x600
LayoutView at (0,0) size 800x600
layer at (0,0) size 800x162
LayoutBlockFlow {HTML} at (0,0) size 800x162
LayoutBlockFlow {BODY} at (8,16) size 784x138
LayoutBlockFlow {P} at (0,0) size 784x20
LayoutText {#text} at (0,0) size 508x19
text run at (0,0) width 508: "crbug.com/35697: The coloured bands show flow seamlessly in the background."
LayoutTable {TABLE} at (0,36) size 228x102
LayoutTableSection {THEAD} at (0,0) size 228x102
LayoutTableRow {TR} at (0,2) size 228x98
LayoutTableCell {TH} at (2,50) size 111x2 [r=0 c=0 rs=1 cs=1]
LayoutTableCell {TH} at (115,50) size 111x2 [r=0 c=1 rs=1 cs=1]
third_party/WebKit/LayoutTests/fast/table/backgr_fixed-bg-table.html deleted 100644 → 0
View file @ 881ef9aa
<!DOCTYPE html>
<style>
.d {width: 109px}
.d {height: 96px}
thead{background:url(resources/rainbowh.gif) fixed;}
</style>
<p>crbug.com/35697: The coloured bands show flow seamlessly in the background.</p>
<table>
<thead>
<tr class="th-row-1">
<th class="d"></th>
<th class="d"></th>
</tr>
</thead>
</table>
third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp
View file @ 06e25257
...@@ -518,7 +518,6 @@ void BackgroundImageGeometry::Calculate(const LayoutBoxModelObject* container, ...@@ -518,7 +518,6 @@ void BackgroundImageGeometry::Calculate(const LayoutBoxModelObject* container,
} }
} else { } else {
SetHasNonLocalGeometry(); SetHasNonLocalGeometry();
offset_in_background_ = LayoutPoint();
positioning_area = FixedAttachmentPositioningArea(box_, container, flags); positioning_area = FixedAttachmentPositioningArea(box_, container, flags);
SetDestRect(positioning_area); SetDestRect(positioning_area);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment