Constraints: Make advanced list be a list.

Previous behavior: A list of optional constraints resulted
in a single advanced element, with one field for each value.

New behavior: A list of optional constraints results in a
list of advanced elements, with one field set for each value.

The difference is important when there are mulitple values
with the same name. For constraints with distinct names, there
should be no difference.

BUG=594929

Review URL: https://codereview.chromium.org/1808173002

Cr-Commit-Position: refs/heads/master@{#381724}

third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp

@@ -434,14 +434,15 @@ static WebMediaConstraints createFromNamedConstraints(ExecutionContext* context,
         return constraints;
     // We ignore unknow names and syntax errors in optional constraints.
     MediaErrorState ignoredErrorState;
-    parseOldStyleNames(context, optional, false, advanced, ignoredErrorState);
-    if (advanced.isEmpty()) {
-        WebVector<WebMediaTrackConstraintSet> emptyVector;
-        constraints.initialize(basic, emptyVector);
-    } else {
-        WebVector<WebMediaTrackConstraintSet> advancedVector(&advanced, 1);
-        constraints.initialize(basic, advancedVector);
-    }
+    Vector<WebMediaTrackConstraintSet> advancedVector;
+    for (const auto& optionalConstraint : optional) {
+        WebMediaTrackConstraintSet advancedElement;
+        WebVector<WebMediaConstraint> elementAsList(&optionalConstraint, 1);
+        parseOldStyleNames(context, elementAsList, false, advancedElement, ignoredErrorState);
+        if (!advancedElement.isEmpty())
+            advancedVector.append(advancedElement);
+    }
+    constraints.initialize(basic, advancedVector);
     return constraints;
 }