Commit 20477755 authored by isherman@chromium.org's avatar isherman@chromium.org

Hopefully fix PersonalDataManagerTest.ImportFormDataNotEnoughFilledFields

Possibly related: http://codereview.chromium.org/6211002/

BUG=67423
TEST=unit_tests

Review URL: http://codereview.chromium.org/6246009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72672 0039d316-1c4b-4281-b951-d872f2087c98
parent b148888f
...@@ -74,7 +74,7 @@ class PersonalDataManagerMock : public PersonalDataManager { ...@@ -74,7 +74,7 @@ class PersonalDataManagerMock : public PersonalDataManager {
class ProfileMock : public TestingProfile { class ProfileMock : public TestingProfile {
public: public:
ProfileMock() { ProfileMock() {
test_manager_ =new PersonalDataManagerMock; test_manager_ = new PersonalDataManagerMock;
} }
virtual ~ProfileMock() {} virtual ~ProfileMock() {}
......
...@@ -543,8 +543,7 @@ TEST_F(PersonalDataManagerTest, ImportFormData) { ...@@ -543,8 +543,7 @@ TEST_F(PersonalDataManagerTest, ImportFormData) {
EXPECT_EQ(0, expected.Compare(*results[0])); EXPECT_EQ(0, expected.Compare(*results[0]));
} }
// Crashy, http://crbug.com/67423. TEST_F(PersonalDataManagerTest, ImportFormDataNotEnoughFilledFields) {
TEST_F(PersonalDataManagerTest, DISABLED_ImportFormDataNotEnoughFilledFields) {
FormData form; FormData form;
webkit_glue::FormField field; webkit_glue::FormField field;
autofill_test::CreateTestFormField( autofill_test::CreateTestFormField(
...@@ -565,6 +564,8 @@ TEST_F(PersonalDataManagerTest, DISABLED_ImportFormDataNotEnoughFilledFields) { ...@@ -565,6 +564,8 @@ TEST_F(PersonalDataManagerTest, DISABLED_ImportFormDataNotEnoughFilledFields) {
EXPECT_CALL(personal_data_observer_, EXPECT_CALL(personal_data_observer_,
OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop()); OnPersonalDataLoaded()).WillOnce(QuitUIMessageLoop());
MessageLoop::current()->Run();
const std::vector<AutoFillProfile*>& profiles = personal_data_->profiles(); const std::vector<AutoFillProfile*>& profiles = personal_data_->profiles();
ASSERT_EQ(0U, profiles.size()); ASSERT_EQ(0U, profiles.size());
const std::vector<CreditCard*>& credit_cards = personal_data_->credit_cards(); const std::vector<CreditCard*>& credit_cards = personal_data_->credit_cards();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment