Commit 210b441b authored by Steve Anton's avatar Steve Anton Committed by Commit Bot

Move to SSLFingerprint methods which return unique_ptr

Bug: None
Change-Id: I07578f0d424764fed0ce93a88b40e0046f1e1527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603343
Auto-Submit: Steve Anton <steveanton@chromium.org>
Commit-Queue: Seth Hampson <shampson@chromium.org>
Reviewed-by: default avatarSeth Hampson <shampson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658290}
parent 11fda847
...@@ -804,14 +804,14 @@ TEST_F(P2PQuicTransportTest, HandshakeConnectsPeersWithRemoteCertificates) { ...@@ -804,14 +804,14 @@ TEST_F(P2PQuicTransportTest, HandshakeConnectsPeersWithRemoteCertificates) {
// Start the handshake with the remote fingerprints. // Start the handshake with the remote fingerprints.
std::vector<std::unique_ptr<rtc::SSLFingerprint>> server_fingerprints; std::vector<std::unique_ptr<rtc::SSLFingerprint>> server_fingerprints;
server_fingerprints.emplace_back(rtc::SSLFingerprint::Create( server_fingerprints.push_back(rtc::SSLFingerprint::CreateUnique(
"sha-256", server_peer()->certificate()->identity())); "sha-256", *server_peer()->certificate()->identity()));
server_peer()->quic_transport()->Start( server_peer()->quic_transport()->Start(
P2PQuicTransport::StartConfig(std::move(server_fingerprints))); P2PQuicTransport::StartConfig(std::move(server_fingerprints)));
std::vector<std::unique_ptr<rtc::SSLFingerprint>> client_fingerprints; std::vector<std::unique_ptr<rtc::SSLFingerprint>> client_fingerprints;
client_fingerprints.emplace_back(rtc::SSLFingerprint::Create( client_fingerprints.push_back(rtc::SSLFingerprint::CreateUnique(
"sha-256", client_peer()->certificate()->identity())); "sha-256", *client_peer()->certificate()->identity()));
client_peer()->quic_transport()->Start( client_peer()->quic_transport()->Start(
P2PQuicTransport::StartConfig(std::move(client_fingerprints))); P2PQuicTransport::StartConfig(std::move(client_fingerprints)));
......
...@@ -265,8 +265,8 @@ static std::unique_ptr<rtc::SSLFingerprint> RTCDtlsFingerprintToSSLFingerprint( ...@@ -265,8 +265,8 @@ static std::unique_ptr<rtc::SSLFingerprint> RTCDtlsFingerprintToSSLFingerprint(
const RTCDtlsFingerprint* dtls_fingerprint) { const RTCDtlsFingerprint* dtls_fingerprint) {
std::string algorithm = WebString(dtls_fingerprint->algorithm()).Utf8(); std::string algorithm = WebString(dtls_fingerprint->algorithm()).Utf8();
std::string value = WebString(dtls_fingerprint->value()).Utf8(); std::string value = WebString(dtls_fingerprint->value()).Utf8();
std::unique_ptr<rtc::SSLFingerprint> rtc_fingerprint( std::unique_ptr<rtc::SSLFingerprint> rtc_fingerprint =
rtc::SSLFingerprint::CreateFromRfc4572(algorithm, value)); rtc::SSLFingerprint::CreateUniqueFromRfc4572(algorithm, value);
DCHECK(rtc_fingerprint); DCHECK(rtc_fingerprint);
return rtc_fingerprint; return rtc_fingerprint;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment