Commit 25d34c4f authored by Caleb Raitto's avatar Caleb Raitto Committed by Commit Bot

Disable leaking views_unittests on LSAN.

See crrev.com/c/1590404 and the linked bug for context -- the goal is to
fix the broken memory-leak checking in Chromium's ASAN
(AddressSanitizer) trybots, which are supposed to also run LSAN
(LeakSanitizer).

Currently-leaking tests must be fixed or disabled before leak checking
can be enabled in the ASAN trybot.

WARNING: This will result in a loss of ASAN coverage for the affected
tests given that LSAN runs as part of the ASAN trybot.

If that's not acceptable, we can wait until the leaks are fixed before
fixing leak detection in trybots, but keep in mind that newly-introduced
leaks Chromium-wide won't be caught until then.

Bug: 961075
Change-Id: Ib3c729da5cf45d77c9130f66cedb911434ccd03f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641562
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666316}
parent a0992a5e
......@@ -59,6 +59,15 @@
#include "ui/base/ui_base_features.h"
#endif
// TODO(crbug.com/961075): Fix memory leaks in tests and re-enable on LSAN.
#ifdef LEAK_SANITIZER
#define MAYBE_SetSelectionIndices_NestedButtons \
DISABLED_SetSelectionIndices_NestedButtons
#else
#define MAYBE_SetSelectionIndices_NestedButtons \
SetSelectionIndices_NestedButtons
#endif
namespace views {
namespace test {
......@@ -2256,7 +2265,7 @@ TEST_F(MenuControllerTest, SetSelectionIndices_Buttons_SkipHiddenAndDisabled) {
EXPECT_EQ(5, data.GetIntAttribute(ax::mojom::IntAttribute::kSetSize));
}
TEST_F(MenuControllerTest, SetSelectionIndices_NestedButtons) {
TEST_F(MenuControllerTest, MAYBE_SetSelectionIndices_NestedButtons) {
class DummyButtonListener : public ButtonListener {
public:
~DummyButtonListener() override = default;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment