Clean up client codes for assistant key remapping.

Delete kAssistantKeyRemapping feature flag and chrome flag since this
feature has been launched.

Bug: none.
Test: local compile and manually test.
Change-Id: Ieb8781dbb60c4ec7049c666ce05f0ce100695ea6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715095Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680115}

chrome/browser/about_flags.cc

@@ -3530,11 +3530,6 @@ const FeatureEntry kFeatureEntries[] = {
      flag_descriptions::kEnableAssistantAppSupportDescription, kOsCrOS,
      FEATURE_VALUE_TYPE(chromeos::assistant::features::kAssistantAppSupport)},
 
-    {"enable-assistant-key-remapping",
-     flag_descriptions::kEnableAssistantKeyRemappingName,
-     flag_descriptions::kEnableAssistantKeyRemappingDescription, kOsCrOS,
-     FEATURE_VALUE_TYPE(chromeos::assistant::features::kAssistantKeyRemapping)},
-
     {"enable-assistant-media-session-integration",
      flag_descriptions::kEnableAssistantMediaSessionIntegrationName,
      flag_descriptions::kEnableAssistantMediaSessionIntegrationDescription,

chrome/browser/flag_descriptions.cc

@@ -3126,11 +3126,6 @@ const char kEnableAssistantAppSupportName[] = "Enable Assistant App Support";
 const char kEnableAssistantAppSupportDescription[] =
     "Enable the Assistant App Support feature";
 
-const char kEnableAssistantKeyRemappingName[] =
-    "Enable Assistant Key Remapping";
-const char kEnableAssistantKeyRemappingDescription[] =
-    "Allow Assistant key remapping in the keyboard settings.";
-
 const char kEnableAssistantLauncherIntegrationName[] =
     "Assistant & Launcher integration";
 const char kEnableAssistantLauncherIntegrationDescription[] =

chrome/browser/flag_descriptions.h

@@ -1870,9 +1870,6 @@ extern const char kEnableArcUnifiedAudioFocusDescription[];
 extern const char kEnableAssistantAppSupportName[];
 extern const char kEnableAssistantAppSupportDescription[];
 
-extern const char kEnableAssistantKeyRemappingName[];
-extern const char kEnableAssistantKeyRemappingDescription[];
-
 extern const char kEnableAssistantLauncherIntegrationName[];
 extern const char kEnableAssistantLauncherIntegrationDescription[];
 

chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc

@@ -11,7 +11,6 @@
 #include "base/values.h"
 #include "chrome/browser/ui/ash/tablet_mode_client.h"
 #include "chromeos/constants/chromeos_switches.h"
-#include "chromeos/services/assistant/public/features.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/common/service_manager_connection.h"
 #include "services/service_manager/public/cpp/connector.h"
@@ -150,9 +149,7 @@ void KeyboardHandler::UpdateShowKeys() {
   keyboard_params.SetKey("hasInternalKeyboard",
                          base::Value(keyboards_state.has_internal_keyboard));
 
-  const bool show_assistant_key_settings =
-      chromeos::assistant::features::IsKeyRemappingEnabled() &&
-      ui::DeviceKeyboardHasAssistantKey();
+  const bool show_assistant_key_settings = ui::DeviceKeyboardHasAssistantKey();
   keyboard_params.SetKey("hasAssistantKey",
                          base::Value(show_assistant_key_settings));
 

chromeos/services/assistant/public/features.cc

@@ -53,9 +53,6 @@ const base::Feature kEnableAssistantAlarmTimerManager{
 const base::Feature kEnablePowerManager{"ChromeOSAssistantEnablePowerManager",
                                         base::FEATURE_DISABLED_BY_DEFAULT};
 
-const base::Feature kAssistantKeyRemapping{"AssistantKeyRemapping",
-                                           base::FEATURE_DISABLED_BY_DEFAULT};
-
 // Enables sending a screen context request ("What's on my screen?" and
 // metalayer selection) as a text query. This is as opposed to sending
 // the request as a contextual cards request.
@@ -95,10 +92,6 @@ bool IsInAssistantNotificationsEnabled() {
   return base::FeatureList::IsEnabled(kInAssistantNotifications);
 }
 
-bool IsKeyRemappingEnabled() {
-  return base::FeatureList::IsEnabled(kAssistantKeyRemapping);
-}
-
 bool IsMediaSessionIntegrationEnabled() {
   return base::FeatureList::IsEnabled(kEnableMediaSessionIntegration);
 }

chromeos/services/assistant/public/features.h

@@ -76,10 +76,6 @@ extern const base::Feature kEnableTextQueriesWithClientDiscourseContext;
 COMPONENT_EXPORT(ASSISTANT_SERVICE_PUBLIC)
 extern const base::Feature kTimerTicks;
 
-// Enables Assistant key remapping on keyboards.
-COMPONENT_EXPORT(ASSISTANT_SERVICE_PUBLIC)
-extern const base::Feature kAssistantKeyRemapping;
-
 COMPONENT_EXPORT(ASSISTANT_SERVICE_PUBLIC) bool IsAlarmTimerManagerEnabled();
 
 COMPONENT_EXPORT(ASSISTANT_SERVICE_PUBLIC) bool IsAppSupportEnabled();