Remove the FastBorderRadius flag

This has shipped and the associated flags can be removed.

Bug: 967076
Change-Id: Ieccdce6cf8daece164047046be06f87c2a146676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982659
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728085}

content/child/runtime_features.cc

@@ -334,8 +334,6 @@ void SetRuntimeFeaturesFromChromiumFeatures() {
   // function and using feature string name with EnableFeatureFromString.
   const RuntimeFeatureToChromiumFeatureMap<const char*>
       runtimeFeatureNameToChromiumFeatureMapping[] = {
-          {"FastBorderRadius", blink::features::kFastBorderRadius,
-           kUseFeatureState},
           {"FontSrcLocalMatching", features::kFontSrcLocalMatching,
            kUseFeatureState},
           {"LegacyWindowsDWriteFontFallback",
@@ -547,7 +545,6 @@ void SetCustomizedRuntimeFeaturesFromCombinedArgs(
     WebRuntimeFeatures::EnableNetInfoDownlinkMax(true);
     WebRuntimeFeatures::EnableFetchMetadata(true);
     WebRuntimeFeatures::EnableFetchMetadataDestination(true);
-    WebRuntimeFeatures::EnableFeatureFromString("FastBorderRadius", true);
     WebRuntimeFeatures::EnableDisplayLocking(true);
   }
 

testing/variations/fieldtrial_testing_config.json

@@ -2616,25 +2616,6 @@
             ]
         }
     ],
-    "FastBorderRadius": [
-        {
-            "platforms": [
-                "android",
-                "chromeos",
-                "linux",
-                "mac",
-                "windows"
-            ],
-            "experiments": [
-                {
-                    "name": "Enabled",
-                    "enable_features": [
-                        "FastBorderRadius"
-                    ]
-                }
-            ]
-        }
-    ],
     "FilterAdsOnAbusiveSites": [
         {
             "platforms": [

third_party/blink/common/features.cc

@@ -58,11 +58,6 @@ const base::Feature kAssumeOverlapAfterFixedOrStickyPosition{
 const base::Feature kDisplayLocking{"DisplayLocking",
                                     base::FEATURE_DISABLED_BY_DEFAULT};
 
-// Enable applying rounded corner masks via a GL shader rather than
-// a mask layer.
-const base::Feature kFastBorderRadius{"FastBorderRadius",
-                                      base::FEATURE_ENABLED_BY_DEFAULT};
-
 const base::Feature kJSONModules{"JSONModules",
                                  base::FEATURE_DISABLED_BY_DEFAULT};
 

third_party/blink/public/common/features.h

@@ -30,7 +30,6 @@ BLINK_COMMON_EXPORT extern const base::Feature kCSSOMViewScrollCoordinates;
 BLINK_COMMON_EXPORT extern const base::Feature kDisplayLocking;
 BLINK_COMMON_EXPORT extern const base::Feature
     kAssumeOverlapAfterFixedOrStickyPosition;
-BLINK_COMMON_EXPORT extern const base::Feature kFastBorderRadius;
 BLINK_COMMON_EXPORT extern const base::Feature kJSONModules;
 BLINK_COMMON_EXPORT extern const base::Feature kLayoutNG;
 BLINK_COMMON_EXPORT extern const base::Feature kMixedContentAutoupgrade;

third_party/blink/renderer/platform/graphics/compositing/property_tree_manager.cc

@@ -794,9 +794,6 @@ void PropertyTreeManager::ForceRenderSurfaceIfSyntheticRoundedCornerClip(
 bool PropertyTreeManager::SupportsShaderBasedRoundedCorner(
     const ClipPaintPropertyNode& clip,
     PropertyTreeManager::CcEffectType type) {
-  if (!RuntimeEnabledFeatures::FastBorderRadiusEnabled())
-    return false;
-
   if (type & CcEffectType::kSyntheticFor2dAxisAlignment)
     return false;
 
@@ -815,11 +812,10 @@ bool PropertyTreeManager::SupportsShaderBasedRoundedCorner(
     return false;
   }
 
-  // Rounded corners that differ are not supported by the
-  // CALayerOverlay system on Mac. Instead of letting it fall back
-  // to the (worse for memory and battery) non-CALayerOverlay system
-  // for such cases, fall back to a non-fast border-radius mask for
-  // the effect node.
+  // Rounded corners that differ are not supported by the CALayerOverlay system
+  // on Mac. Instead of letting it fall back to the (worse for memory and
+  // battery) non-CALayerOverlay system for such cases, fall back to a
+  // non-shader border-radius mask for the effect node.
 #if defined(OS_MACOSX)
   if (radii.TopLeft() != radii.TopRight() ||
       radii.TopLeft() != radii.BottomRight() ||

third_party/blink/renderer/platform/runtime_enabled_features.json5

@@ -700,10 +700,6 @@
     {
       name: "FallbackCursorMode",
     },
-    {
-      name: "FastBorderRadius",
-      status: "experimental",
-    },
     {
       name: "FeaturePolicyForClientHints",
       status: "experimental",

third_party/blink/renderer/platform/testing/paint_test_configurations.h

@@ -11,23 +11,17 @@
 
 namespace blink {
 
-enum {
-  kCompositeAfterPaint = 1 << 0,
-  kUnderInvalidationChecking = 1 << 1,
-  kFastBorderRadius = 1 << 2
-};
+enum { kCompositeAfterPaint = 1 << 0, kUnderInvalidationChecking = 1 << 1 };
 
 class PaintTestConfigurations
     : public testing::WithParamInterface<unsigned>,
       private ScopedCompositeAfterPaintForTest,
-      private ScopedPaintUnderInvalidationCheckingForTest,
-      private ScopedFastBorderRadiusForTest {
+      private ScopedPaintUnderInvalidationCheckingForTest {
  public:
   PaintTestConfigurations()
       : ScopedCompositeAfterPaintForTest(GetParam() & kCompositeAfterPaint),
-        ScopedPaintUnderInvalidationCheckingForTest(GetParam() &
-                                                    kUnderInvalidationChecking),
-        ScopedFastBorderRadiusForTest(GetParam() & kFastBorderRadius) {}
+        ScopedPaintUnderInvalidationCheckingForTest(
+            GetParam() & kUnderInvalidationChecking) {}
   ~PaintTestConfigurations() {
     // Must destruct all objects before toggling back feature flags.
     WebHeap::CollectAllGarbageForTesting();
@@ -42,10 +36,10 @@ class PaintTestConfigurations
   INSTANTIATE_TEST_SUITE_P(All, test_class,      \
                            ::testing::Values(kCompositeAfterPaint))
 
+// TODO(pdr): Remove this in favor of INSTANTIATE_PAINT_TEST_SUITE_P.
 #define INSTANTIATE_LAYER_LIST_TEST_SUITE_P(test_class) \
-  INSTANTIATE_TEST_SUITE_P(                             \
-      All, test_class,                                  \
-      ::testing::Values(0, kCompositeAfterPaint, kFastBorderRadius))
+  INSTANTIATE_TEST_SUITE_P(All, test_class,             \
+                           ::testing::Values(0, kCompositeAfterPaint))
 
 #define INSTANTIATE_SCROLL_HIT_TEST_SUITE_P(test_class) \
   INSTANTIATE_TEST_SUITE_P(All, test_class,             \