Commit 31aaefcb authored by Michael Lippautz's avatar Michael Lippautz Committed by Commit Bot

[unified-heap] Fix CredentialsContainerTest for unified heap GCs

Bug: 902286, 843903
Change-Id: I2f4a836bfb448e092a7301a326c0caed722d607e
Reviewed-on: https://chromium-review.googlesource.com/c/1329175Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606917}
parent 0c7bb2bf
......@@ -120,9 +120,7 @@ class CredentialManagerTestingContext {
// The completion callbacks for pending mojom::CredentialManager calls each own
// a persistent handle to a ScriptPromiseResolver instance. Ensure that if the
// document is destored while a call is pending, it can still be freed up.
// TODO(https://crbug.com/902286): This test was disabled due to failures caused
// by "unified garbage collections", fix the test and re-enable it.
TEST(CredentialsContainerTest, DISABLED_PendingGetRequest_NoGCCycles) {
TEST(CredentialsContainerTest, PendingGetRequest_NoGCCycles) {
MockCredentialManager mock_credential_manager;
GCObjectLivenessObserver<Document> document_observer;
......@@ -134,7 +132,9 @@ TEST(CredentialsContainerTest, DISABLED_PendingGetRequest_NoGCCycles) {
mock_credential_manager.WaitForCallToGet();
}
V8GCController::CollectAllGarbageForTesting(v8::Isolate::GetCurrent());
V8GCController::CollectAllGarbageForTesting(
v8::Isolate::GetCurrent(),
v8::EmbedderHeapTracer::EmbedderStackState::kEmpty);
ThreadState::Current()->CollectAllGarbage();
ASSERT_TRUE(document_observer.WasCollected());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment