Commit 4267f6b7 authored by nednguyen's avatar nednguyen Committed by Commit bot

[tools/perf] Add a broken page to dummy_benchmark.noisy_benchmark_1

*PERF SHERRIF: this CL intentionally breaks dummy_benchmark.noisy_benchmark_1
for intergration testing purpose.
Please coordinate with prasadv@ before your revert this.

BUG=537676, 581465

Review URL: https://codereview.chromium.org/1439453002

Cr-Commit-Position: refs/heads/master@{#371640}
parent 8da2e8e2
...@@ -16,7 +16,7 @@ from core import perf_benchmark ...@@ -16,7 +16,7 @@ from core import perf_benchmark
from telemetry.value import scalar from telemetry.value import scalar
from telemetry.page import page_test from telemetry.page import page_test
import page_sets from page_sets import dummy_story_set
class _DummyTest(page_test.PageTest): class _DummyTest(page_test.PageTest):
...@@ -35,7 +35,7 @@ class _DummyTest(page_test.PageTest): ...@@ -35,7 +35,7 @@ class _DummyTest(page_test.PageTest):
class _DummyBenchmark(perf_benchmark.PerfBenchmark): class _DummyBenchmark(perf_benchmark.PerfBenchmark):
page_set = page_sets.DummyStorySet page_set = dummy_story_set.DummyStorySet
class DummyBenchmarkOne(_DummyBenchmark): class DummyBenchmarkOne(_DummyBenchmark):
...@@ -58,3 +58,9 @@ class DummyBenchmarkTwo(_DummyBenchmark): ...@@ -58,3 +58,9 @@ class DummyBenchmarkTwo(_DummyBenchmark):
@classmethod @classmethod
def Name(cls): def Name(cls):
return 'dummy_benchmark.noisy_benchmark_1' return 'dummy_benchmark.noisy_benchmark_1'
def CreateStorySet(self, options):
del options # unused
story_set = dummy_story_set.DummyStorySet()
story_set.AddStory(dummy_story_set.BrokenDummyPage(story_set))
return story_set
...@@ -12,10 +12,23 @@ class DummyPage(page_module.Page): ...@@ -12,10 +12,23 @@ class DummyPage(page_module.Page):
url='file://dummy_page.html', url='file://dummy_page.html',
page_set=page_set) page_set=page_set)
def PerformPageInteractions(self, action_runner): def RunPageInteractions(self, action_runner):
assert action_runner.EvaluateJavaScript('1 + window.__dummy_value') == 2 assert action_runner.EvaluateJavaScript('1 + window.__dummy_value') == 2
class BrokenDummyPage(page_module.Page):
def __init__(self, page_set):
super(BrokenDummyPage, self).__init__(
url='file://dummy_page.html',
name='Broken dummy page',
page_set=page_set)
def RunPageInteractions(self, action_runner):
# The call below should raise an AssertionError
assert action_runner.EvaluateJavaScript('1 + window.__dummy_value') == 3
class DummyStorySet(story.StorySet): class DummyStorySet(story.StorySet):
def __init__(self): def __init__(self):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment