Commit 4737caa5 authored by Dan Beam's avatar Dan Beam Committed by Commit Bot

Chrome New Tab Page: start adding a "real" search box ("realbox")

This CL simply adds a feature ([k]NtpRealbox).

This is for a11y purposes and to fix the [currently somewhat broken]
NTP fullscreen experience, and to allow on-focus suggestions.

R=mahmadi@chromium.org
BUG=243926, 778489, 996516

Change-Id: Ic7347be02391290dfc6214a1754558e91b6c7802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769035
Auto-Submit: Dan Beam <dbeam@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: default avatarMoe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690397}
parent 93cbcb5e
...@@ -35,4 +35,10 @@ const base::Feature kNtpCustomizationMenuV2{"NtpCustomizationMenuV2", ...@@ -35,4 +35,10 @@ const base::Feature kNtpCustomizationMenuV2{"NtpCustomizationMenuV2",
const base::Feature kFirstRunDefaultSearchShortcut{ const base::Feature kFirstRunDefaultSearchShortcut{
"FirstRunDefaultSearchShortcut", base::FEATURE_DISABLED_BY_DEFAULT}; "FirstRunDefaultSearchShortcut", base::FEATURE_DISABLED_BY_DEFAULT};
// If enabled, the search box in the middle of the NTP will accept input
// directly (i.e. not be a "fake" box) and search results will show directly
// below the non-fake input ("realbox").
const base::Feature kNtpRealbox{"NtpRealbox",
base::FEATURE_DISABLED_BY_DEFAULT};
} // namespace features } // namespace features
...@@ -20,6 +20,8 @@ extern const base::Feature kNtpCustomizationMenuV2; ...@@ -20,6 +20,8 @@ extern const base::Feature kNtpCustomizationMenuV2;
extern const base::Feature kFirstRunDefaultSearchShortcut; extern const base::Feature kFirstRunDefaultSearchShortcut;
extern const base::Feature kNtpRealbox;
} // namespace features } // namespace features
#endif // CHROME_BROWSER_SEARCH_NTP_FEATURES_H_ #endif // CHROME_BROWSER_SEARCH_NTP_FEATURES_H_
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment