Commit 4ed01096 authored by Donn Denman's avatar Donn Denman Committed by Commit Bot

[Omnibox] Disable some tests on Android > KitKat.

Disables a few Omnibox tests on all versions of Android beyond KitKat
because they are flaky.

This is a correction to https://crrev.com/c/1931856 which got the sense
of the disabling for > KitKat backwards.

BUG=1027549
TBR=twellington@chromium.org

Change-Id: I91be9e20633fbc418e2cb0bfd1d3101d95b6f8e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932170
Commit-Queue: Donn Denman <donnd@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: default avatarChris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#718939}
parent a7962e78
...@@ -141,7 +141,8 @@ public class OmniboxTest { ...@@ -141,7 +141,8 @@ public class OmniboxTest {
* Test for checking whether soft input model switches with focus. * Test for checking whether soft input model switches with focus.
*/ */
@Test @Test
@DisableIf.Build(sdk_is_less_than = Build.VERSION_CODES.LOLLIPOP, message = "crbug.com/1027549") @DisableIf.
Build(sdk_is_greater_than = Build.VERSION_CODES.KITKAT, message = "crbug.com/1027549")
@MediumTest @MediumTest
@Feature({"Omnibox"}) @Feature({"Omnibox"})
@RetryOnFailure @RetryOnFailure
...@@ -215,7 +216,8 @@ public class OmniboxTest { ...@@ -215,7 +216,8 @@ public class OmniboxTest {
* Tests that focusing a url bar starts a zero suggest request. * Tests that focusing a url bar starts a zero suggest request.
*/ */
@Test @Test
@DisableIf.Build(sdk_is_less_than = Build.VERSION_CODES.LOLLIPOP, message = "crbug.com/1027549") @DisableIf.
Build(sdk_is_greater_than = Build.VERSION_CODES.KITKAT, message = "crbug.com/1027549")
@MediumTest @MediumTest
@Feature({"Omnibox"}) @Feature({"Omnibox"})
@RetryOnFailure @RetryOnFailure
...@@ -260,7 +262,8 @@ public class OmniboxTest { ...@@ -260,7 +262,8 @@ public class OmniboxTest {
} }
@Test @Test
@DisableIf.Build(sdk_is_less_than = Build.VERSION_CODES.LOLLIPOP, message = "crbug.com/1027549") @DisableIf.
Build(sdk_is_greater_than = Build.VERSION_CODES.KITKAT, message = "crbug.com/1027549")
@MediumTest @MediumTest
@Feature({"Omnibox"}) @Feature({"Omnibox"})
@RetryOnFailure @RetryOnFailure
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment