Commit 4f046e85 authored by dcheng's avatar dcheng Committed by Commit bot

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //dbus

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

BUG=581865

Review-Url: https://codereview.chromium.org/2037833003
Cr-Commit-Position: refs/heads/master@{#398228}
parent 53847636
...@@ -204,7 +204,7 @@ TEST(ValuesUtilTest, PopIntArray) { ...@@ -204,7 +204,7 @@ TEST(ValuesUtilTest, PopIntArray) {
// Create the expected value. // Create the expected value.
std::unique_ptr<base::ListValue> list_value(new base::ListValue); std::unique_ptr<base::ListValue> list_value(new base::ListValue);
for (size_t i = 0; i != data.size(); ++i) for (size_t i = 0; i != data.size(); ++i)
list_value->Append(new base::FundamentalValue(data[i])); list_value->AppendInteger(data[i]);
// Pop an int32_t array. // Pop an int32_t array.
MessageReader reader(response.get()); MessageReader reader(response.get());
...@@ -227,7 +227,7 @@ TEST(ValuesUtilTest, PopStringArray) { ...@@ -227,7 +227,7 @@ TEST(ValuesUtilTest, PopStringArray) {
// Create the expected value. // Create the expected value.
std::unique_ptr<base::ListValue> list_value(new base::ListValue); std::unique_ptr<base::ListValue> list_value(new base::ListValue);
for (size_t i = 0; i != data.size(); ++i) for (size_t i = 0; i != data.size(); ++i)
list_value->Append(new base::StringValue(data[i])); list_value->AppendString(data[i]);
// Pop a string array. // Pop a string array.
MessageReader reader(response.get()); MessageReader reader(response.get());
...@@ -254,10 +254,10 @@ TEST(ValuesUtilTest, PopStruct) { ...@@ -254,10 +254,10 @@ TEST(ValuesUtilTest, PopStruct) {
// Create the expected value. // Create the expected value.
base::ListValue list_value; base::ListValue list_value;
list_value.Append(new base::FundamentalValue(kBoolValue)); list_value.AppendBoolean(kBoolValue);
list_value.Append(new base::FundamentalValue(kInt32Value)); list_value.AppendInteger(kInt32Value);
list_value.Append(new base::FundamentalValue(kDoubleValue)); list_value.AppendDouble(kDoubleValue);
list_value.Append(new base::StringValue(kStringValue)); list_value.AppendString(kStringValue);
// Pop a struct. // Pop a struct.
MessageReader reader(response.get()); MessageReader reader(response.get());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment