Commit 589815e2 authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Disable flaky MediaEngagementBrowserTest.RecordSingleVisitOnSameOrigin.

The test times out in a flaky manner on several platforms, so disable
them there.

TBR=mlamouri@chromium.org

Bug: 1014229
Change-Id: I2d030a0e26f207e07f1c9a4e4a9b174e1b46e78c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860309Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705690}
parent f2848504
...@@ -11,6 +11,7 @@ ...@@ -11,6 +11,7 @@
#include "base/test/test_mock_time_task_runner.h" #include "base/test/test_mock_time_task_runner.h"
#include "base/time/time.h" #include "base/time/time.h"
#include "base/timer/timer.h" #include "base/timer/timer.h"
#include "build/build_config.h"
#include "chrome/browser/browser_process.h" #include "chrome/browser/browser_process.h"
#include "chrome/browser/component_updater/mei_preload_component_installer.h" #include "chrome/browser/component_updater/mei_preload_component_installer.h"
#include "chrome/browser/media/media_engagement_contents_observer.h" #include "chrome/browser/media/media_engagement_contents_observer.h"
...@@ -477,8 +478,16 @@ IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, RecordVisitOnBrowserClose) { ...@@ -477,8 +478,16 @@ IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, RecordVisitOnBrowserClose) {
ExpectScores(1, 0, 1, 0); ExpectScores(1, 0, 1, 0);
} }
#if defined(OS_WIN) || defined(OS_LINUX)
// Flaky timeout. https://crbug.com/1014229
#define MAYBE_RecordSingleVisitOnSameOrigin \
DISABLED_RecordSingleVisitOnSameOrigin
#else
#define MAYBE_RecordSingleVisitOnSameOrigin RecordSingleVisitOnSameOrigin
#endif
IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest, IN_PROC_BROWSER_TEST_F(MediaEngagementBrowserTest,
RecordSingleVisitOnSameOrigin) { MAYBE_RecordSingleVisitOnSameOrigin) {
LoadTestPageAndWaitForPlayAndAudible("engagement_test_small_frame_size.html", LoadTestPageAndWaitForPlayAndAudible("engagement_test_small_frame_size.html",
false); false);
AdvanceMeaningfulPlaybackTime(); AdvanceMeaningfulPlaybackTime();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment