Commit 58aed91e authored by Jimmy Gong's avatar Jimmy Gong Committed by Commit Bot

Rename Print management app to Print jobs

- Rename the app name from "Print Management App" to "Print Jobs" for
  consistency with the settings entry point and app title.

Bug: 1106142
Change-Id: I0dd0aaecefe03f52b46a0154a090ecdf417b1ccc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303970
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789626}
parent a5a3cd26
...@@ -27,7 +27,7 @@ IN_PROC_BROWSER_TEST_P(PrintManagementAppIntegrationTest, ...@@ -27,7 +27,7 @@ IN_PROC_BROWSER_TEST_P(PrintManagementAppIntegrationTest,
PrintManagementAppInLauncher) { PrintManagementAppInLauncher) {
const GURL url(chromeos::kChromeUIPrintManagementAppUrl); const GURL url(chromeos::kChromeUIPrintManagementAppUrl);
EXPECT_NO_FATAL_FAILURE(ExpectSystemWebAppValid( EXPECT_NO_FATAL_FAILURE(ExpectSystemWebAppValid(
web_app::SystemAppType::PRINT_MANAGEMENT, url, "Print Management App")); web_app::SystemAppType::PRINT_MANAGEMENT, url, "Print Jobs"));
} }
INSTANTIATE_TEST_SUITE_P(All, INSTANTIATE_TEST_SUITE_P(All,
......
...@@ -339,6 +339,9 @@ Try tapping the mic to ask me anything. ...@@ -339,6 +339,9 @@ Try tapping the mic to ask me anything.
<message name="IDS_PRINT_MANAGEMENT_TITLE" desc="The title of the print management app."> <message name="IDS_PRINT_MANAGEMENT_TITLE" desc="The title of the print management app.">
Print jobs Print jobs
</message> </message>
<message name="IDS_PRINT_MANAGEMENT_APP_NAME" desc="The app name of the print management app.">
Print Jobs
</message>
<message name="IDS_PRINT_MANAGEMENT_CLEAR_ALL_HISTORY_BUTTON_TEXT" desc="The label for the button that clears the print job history."> <message name="IDS_PRINT_MANAGEMENT_CLEAR_ALL_HISTORY_BUTTON_TEXT" desc="The label for the button that clears the print job history.">
Clear all history Clear all history
</message> </message>
......
f62f08e78643f5865a9093e03383088d9715fa91
\ No newline at end of file
...@@ -14,6 +14,7 @@ static_library("print_management") { ...@@ -14,6 +14,7 @@ static_library("print_management") {
deps = [ deps = [
"//chromeos/components/print_management/mojom", "//chromeos/components/print_management/mojom",
"//chromeos/components/web_applications",
"//chromeos/constants", "//chromeos/constants",
"//chromeos/resources:print_management_resources", "//chromeos/resources:print_management_resources",
"//chromeos/strings/", "//chromeos/strings/",
......
...@@ -8,6 +8,7 @@ ...@@ -8,6 +8,7 @@
#include "base/memory/ptr_util.h" #include "base/memory/ptr_util.h"
#include "chromeos/components/print_management/mojom/printing_manager.mojom.h" #include "chromeos/components/print_management/mojom/printing_manager.mojom.h"
#include "chromeos/components/print_management/url_constants.h" #include "chromeos/components/print_management/url_constants.h"
#include "chromeos/components/web_applications/manifest_request_filter.h"
#include "chromeos/constants/chromeos_features.h" #include "chromeos/constants/chromeos_features.h"
#include "chromeos/grit/chromeos_print_management_resources.h" #include "chromeos/grit/chromeos_print_management_resources.h"
#include "chromeos/grit/chromeos_print_management_resources_map.h" #include "chromeos/grit/chromeos_print_management_resources_map.h"
...@@ -115,6 +116,9 @@ PrintManagementUI::PrintManagementUI( ...@@ -115,6 +116,9 @@ PrintManagementUI::PrintManagementUI(
IDR_PRINTING_MANAGER_MOJO_LITE_JS); IDR_PRINTING_MANAGER_MOJO_LITE_JS);
AddPrintManagementStrings(html_source.get()); AddPrintManagementStrings(html_source.get());
web_app::SetManifestRequestFilter(html_source.get(),
IDR_PRINT_MANAGEMENT_MANIFEST,
IDS_PRINT_MANAGEMENT_APP_NAME);
if (base::FeatureList::IsEnabled(chromeos::features::kScanningUI)) { if (base::FeatureList::IsEnabled(chromeos::features::kScanningUI)) {
html_source->AddResourcePath("scanning_page.js", IDR_SCANNING_PAGE_JS); html_source->AddResourcePath("scanning_page.js", IDR_SCANNING_PAGE_JS);
......
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
<html> <html>
<head> <head>
<meta charset="utf-8"> <meta charset="utf-8">
<title>Print Jobs</title> <title>$i18n{printJobTitle}</title>
<style> <style>
html { html {
background-color: var(--cros-bg-color); background-color: var(--cros-bg-color);
......
{ {
"name": "Print Management App", "name": "$i18nRaw{name}",
"short_name": "Print Management", "short_name": "$i18nRaw{name}",
"start_url": "/", "start_url": "/",
"display": "standalone", "display": "standalone",
"theme_color": "#ffffff", "theme_color": "#ffffff",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment