Rename Print management app to Print jobs

- Rename the app name from "Print Management App" to "Print Jobs" for consistency with the settings entry point and app title. Bug: 1106142 Change-Id: I0dd0aaecefe03f52b46a0154a090ecdf417b1ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303970 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#789626}

Rename Print management app to Print jobs
- Rename the app name from "Print Management App" to "Print Jobs" for consistency with the settings entry point and app title. Bug: 1106142 Change-Id: I0dd0aaecefe03f52b46a0154a090ecdf417b1ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303970 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#789626}
58aed91e · Jimmy Gong · Commit Bot · a5a3cd26 · 58aed91e · 58aed91e
Commit 58aed91e authored Jul 17, 2020 by Jimmy Gong Committed by Commit Bot Jul 17, 2020
7 changed files
--- a/chrome/browser/chromeos/web_applications/print_management_app_integration_browsertest.cc
+++ b/chrome/browser/chromeos/web_applications/print_management_app_integration_browsertest.cc
@@ -27,7 +27,7 @@ IN_PROC_BROWSER_TEST_P(PrintManagementAppIntegrationTest,
                       PrintManagementAppInLauncher) {
  const GURL url(chromeos::kChromeUIPrintManagementAppUrl);
  EXPECT_NO_FATAL_FAILURE(ExpectSystemWebAppValid(
-      web_app::SystemAppType::PRINT_MANAGEMENT, url, "Print Management App"));
+      web_app::SystemAppType::PRINT_MANAGEMENT, url, "Print Jobs"));
 }

 INSTANTIATE_TEST_SUITE_P(All,

--- a/chromeos/chromeos_strings.grd
+++ b/chromeos/chromeos_strings.grd
@@ -339,6 +339,9 @@ Try tapping the mic to ask me anything.
      <message name="IDS_PRINT_MANAGEMENT_TITLE" desc="The title of the print management app.">
        Print jobs
      </message>
+      <message name="IDS_PRINT_MANAGEMENT_APP_NAME" desc="The app name of the print management app.">
+        Print Jobs
+      </message>
      <message name="IDS_PRINT_MANAGEMENT_CLEAR_ALL_HISTORY_BUTTON_TEXT" desc="The label for the button that clears the print job history.">
        Clear all history
      </message>

--- a/chromeos/chromeos_strings_grd/IDS_PRINT_MANAGEMENT_APP_NAME.png.sha1
+++ b/chromeos/chromeos_strings_grd/IDS_PRINT_MANAGEMENT_APP_NAME.png.sha1
+f62f08e78643f5865a9093e03383088d9715fa91
\ No newline at end of file
--- a/chromeos/components/print_management/BUILD.gn
+++ b/chromeos/components/print_management/BUILD.gn
@@ -14,6 +14,7 @@ static_library("print_management") {

  deps = [
    "//chromeos/components/print_management/mojom",
+    "//chromeos/components/web_applications",
    "//chromeos/constants",
    "//chromeos/resources:print_management_resources",
    "//chromeos/strings/",

--- a/chromeos/components/print_management/print_management_ui.cc
+++ b/chromeos/components/print_management/print_management_ui.cc
@@ -8,6 +8,7 @@
 #include "base/memory/ptr_util.h"
 #include "chromeos/components/print_management/mojom/printing_manager.mojom.h"
 #include "chromeos/components/print_management/url_constants.h"
+#include "chromeos/components/web_applications/manifest_request_filter.h"
 #include "chromeos/constants/chromeos_features.h"
 #include "chromeos/grit/chromeos_print_management_resources.h"
 #include "chromeos/grit/chromeos_print_management_resources_map.h"
@@ -115,6 +116,9 @@ PrintManagementUI::PrintManagementUI(
                               IDR_PRINTING_MANAGER_MOJO_LITE_JS);

  AddPrintManagementStrings(html_source.get());
+  web_app::SetManifestRequestFilter(html_source.get(),
+                                    IDR_PRINT_MANAGEMENT_MANIFEST,
+                                    IDS_PRINT_MANAGEMENT_APP_NAME);

  if (base::FeatureList::IsEnabled(chromeos::features::kScanningUI)) {
    html_source->AddResourcePath("scanning_page.js", IDR_SCANNING_PAGE_JS);

--- a/chromeos/components/print_management/resources/index.html
+++ b/chromeos/components/print_management/resources/index.html
@@ -5,7 +5,7 @@
 <html>
  <head>
    <meta charset="utf-8">
-    <title>Print Jobs</title>
+    <title>$i18n{printJobTitle}</title>
    <style>
      html {
        background-color: var(--cros-bg-color);

--- a/chromeos/components/print_management/resources/manifest.json
+++ b/chromeos/components/print_management/resources/manifest.json
 {
-    "name": "Print Management App",
-    "short_name": "Print Management",
+    "name": "$i18nRaw{name}",
+    "short_name": "$i18nRaw{name}",
    "start_url": "/",
    "display": "standalone",
    "theme_color": "#ffffff",