Commit 69b8ea5c authored by Charlie Andrews's avatar Charlie Andrews Committed by Commit Bot

Add Nexus 5X disables for all tests disabled on Nexus 5

This is necessary in order to fix http://crbug.com/894906, where all
tests disabled on Nexus 5 were accidentally disabled on Nexus 5X
"Nexus 5X" contains the string "Nexus 5", and we were targeting the
disables based on substring matching.

I erred on the side of being redundant: if there was both a "Nexus 5"
disable and an "Android" disable, I added a corresponding "Nexus 5X"
disable. My idea here was that, if at some later point the "All" bug
got fixed and the test got reenabled, I didn't want the person doing
that to be confused why the story was failing on Nexus 5X still.
Associating the logic bug with the disable explicitly reduces that
confusion.

Bug: 894906
Change-Id: I601304a979c7b7c6451d1571f8ffce61a60f4ecd
Reviewed-on: https://chromium-review.googlesource.com/c/1355482Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Reviewed-by: default avatarCaleb Rouleau <crouleau@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612294}
parent 0c01bcd3
......@@ -10,11 +10,16 @@
# Benchmark: blink_perf.bindings
crbug.com/882881 [ Nexus_5 ] blink_perf.bindings/structured-clone-json-deserialize.html [ Skip ]
crbug.com/910207 [ Nexus_5X ] blink_perf.bindings/structured-clone-json-deserialize.html [ Skip ]
crbug.com/882881 [ Nexus_5 ] blink_perf.bindings/structured-clone-json-serialize.html [ Skip ]
crbug.com/910207 [ Nexus_5X ] blink_perf.bindings/structured-clone-json-serialize.html [ Skip ]
crbug.com/882881 [ Nexus_5 ] blink_perf.bindings/structured-clone-long-string-deserialize.html [ Skip ]
crbug.com/910207 [ Nexus_5X ] blink_perf.bindings/structured-clone-long-string-deserialize.html [ Skip ]
crbug.com/893209 [ Nexus5X_Webview ] blink_perf.bindings/structured-clone-long-string-deserialize.html [ Skip ]
crbug.com/882881 [ Nexus_5 ] blink_perf.bindings/structured-clone-long-string-serialize.html [ Skip ]
crbug.com/910207 [ Nexus_5X ] blink_perf.bindings/structured-clone-long-string-serialize.html [ Skip ]
crbug.com/882881 [ Nexus_5 ] blink_perf.bindings/worker-structured-clone-json-roundtrip.html [ Skip ]
crbug.com/910207 [ Nexus_5X ] blink_perf.bindings/worker-structured-clone-json-roundtrip.html [ Skip ]
crbug.com/882881 [ Nexus_5 ] blink_perf.bindings/worker-structured-clone-json-to-worker.html [ Skip ]
crbug.com/882881 [ Nexus_5X ] blink_perf.bindings/worker-structured-clone-json-to-worker.html [ Skip ]
crbug.com/882881 [ Nexus_5 ] blink_perf.bindings/worker-structured-clone-json-from-worker.html [ Skip ]
......@@ -38,10 +43,12 @@ crbug.com/891878 [ Nexus5X_Webview ] blink_perf.css/CustomPropertiesVarAlias.htm
# Benchmark: blink_perf.layout
crbug.com/551950 [ Android_Svelte ] blink_perf.layout/* [ Skip ]
crbug.com/832686 [ Nexus_5 ] blink_perf.layout/subtree-detaching.html [ Skip ]
crbug.com/910207 [ Nexus_5X ] blink_perf.layout/subtree-detaching.html [ Skip ]
# Benchmark: blink_perf.paint
crbug.com/574483 [ Android_Svelte ] blink_perf.paint/* [ Skip ]
crbug.com/799540 [ Nexus_5 ] blink_perf.paint/* [ Skip ]
crbug.com/910207 [ Nexus_5X ] blink_perf.paint/* [ Skip ]
crbug.com/859979 [ Android_Webview ] blink_perf.paint/paint-offset-changes.html [ Skip ]
crbug.com/901493 [ Nexus6_Webview ] blink_perf.paint/* [ Skip ]
......@@ -88,6 +95,7 @@ crbug.com/879833 [ All ] loading.desktop/Walgreens_warm [ Skip ]
# Benchmark: loading.mobile
crbug.com/656861 [ All ] loading.mobile/G1 [ Skip ]
crbug.com/857108 [ Nexus_5 ] loading.mobile/G1_3g [ Skip ]
crbug.com/910207 [ Nexus_5X ] loading.mobile/G1_3g [ Skip ]
[ Nexus_5X ] loading.mobile/Hongkiat [ Skip ]
[ Nexus_5X ] loading.mobile/Dramaq [ Skip ]
crbug.com/859597 [ All ] loading.mobile/Bradesco_3g [ Skip ]
......@@ -105,8 +113,10 @@ crbug.com/859597 [ All ] loading.mobile/TheStar_3g [ Skip ]
crbug.com/859597 [ All ] loading.mobile/YahooNews_3g [ Skip ]
crbug.com/859597 [ Nexus_5 ] loading.mobile/FlipBoard_cold_3g [ Skip ]
crbug.com/862663 [ Nexus_5 ] loading.mobile/GoogleBrazil_3g [ Skip ]
crbug.com/910207 [ Nexus_5X ] loading.mobile/GoogleBrazil_3g [ Skip ]
crbug.com/862663 [ Nexus_5 ] loading.mobile/GoogleIndonesia_3g [ Skip ]
crbug.com/862663 [ Nexus_5 ] loading.mobile/GoogleRedirectToGoogleJapan_3g [ Skip ]
crbug.com/910207 [ Nexus_5X ] loading.mobile/GoogleRedirectToGoogleJapan_3g [ Skip ]
crbug.com/859597 [ Nexus_5X ] loading.mobile/FlipBoard_cold_3g [ Skip ]
crbug.com/859597 [ Nexus_5 ] loading.mobile/Hongkiat_3g [ Skip ]
crbug.com/859597 [ Nexus_5X ] loading.mobile/Hongkiat_3g [ Skip ]
......@@ -166,6 +176,7 @@ crbug.com/785485 [ Android_Webview ] rendering.mobile/kevs_3d [ Skip ]
crbug.com/785286 [ Android_Webview ] rendering.mobile/smash_cat [ Skip ]
crbug.com/785286 [ Android_Webview ] rendering.mobile/effect_games [ Skip ]
crbug.com/364248 [ Nexus_5 ] rendering.mobile/geo_apis [ Skip ]
crbug.com/910207 [ Nexus_5X ] rendering.mobile/geo_apis [ Skip ]
crbug.com/825234 [ Android_Webview ] rendering.mobile/bouncing_balls_shadow [ Skip ]
crbug.com/350692 [ All ] rendering.mobile/microsoft_performance [ Skip ]
crbug.com/755556 [ Android ] rendering.mobile/balls_css_key_frame_animations_composited_transform [ Skip ]
......@@ -204,6 +215,7 @@ crbug.com/873013 [ Android_Webview ] rendering.mobile/yahoo_answers_mobile_2018
crbug.com/893197 [ Nexus_5X ] rendering.mobile/yahoo_answers_mobile_2018 [ Skip ]
crbug.com/865400 [ Pixel_2 ] rendering.mobile/yahoo_answers_mobile_2018 [ Skip ]
crbug.com/874935 [ Nexus_5 ] rendering.mobile/yahoo_news_2018 [ Skip ]
crbug.com/910207 [ Nexus_5X ] rendering.mobile/yahoo_news_2018 [ Skip ]
crbug.com/901526 [ All ] rendering.mobile/microsoft_fireflies [ Skip ]
# Benchmark: rasterize_and_record_micro.top_25
......@@ -212,8 +224,9 @@ crbug.com/815193 [ Android ] rasterize_and_record_micro.top_25/file://static_top
crbug.com/873011 [ Android_Webview ] rasterize_and_record_micro.top_25/file://static_top_25/yahoonews.html [ Skip ]
crbug.com/865400 [ Pixel_2 ] rasterize_and_record_micro.top_25/file://static_top_25/yahoonews.html [ Skip ]
crbug.com/865400 [ Nexus_5 ] rasterize_and_record_micro.top_25/file://static_top_25/yahoonews.html [ Skip ]
crbug.com/892223 [ Nexus_5 ] rasterize_and_record_micro.top_25/file://static_top_25/yahoogames.html [ Skip ]
crbug.com/865400 [ Nexus_5X ] rasterize_and_record_micro.top_25/file://static_top_25/yahoonews.html [ Skip ]
crbug.com/892223 [ Nexus_5 ] rasterize_and_record_micro.top_25/file://static_top_25/yahoogames.html [ Skip ]
crbug.com/910207 [ Nexus_5X ] rasterize_and_record_micro.top_25/file://static_top_25/yahoogames.html [ Skip ]
crbug.com/875878 [ Nexus6_Webview ] rasterize_and_record_micro.top_25/file://static_top_25/yahoogames.html [ Skip ]
# Benchmark: startup.mobile
......@@ -271,10 +284,13 @@ crbug.com/867853 [ Nexus_5X ] system_health.memory_mobile/browse:chrome:newtab [
crbug.com/657433 [ Android ] system_health.memory_mobile/load:tools:gmail [ Skip ]
crbug.com/708300 [ Android ] system_health.memory_mobile/browse:shopping:flipkart [ Skip ]
crbug.com/784400 [ Nexus_5 ] system_health.memory_mobile/background:tools:gmail [ Skip ]
crbug.com/910207 [ Nexus_5X ] system_health.memory_mobile/background:tools:gmail [ Skip ]
crbug.com/780779 [ Nexus_5 ] system_health.memory_mobile/browse:social:facebook [ Skip ]
crbug.com/910207 [ Nexus_5X ] system_health.memory_mobile/browse:social:facebook [ Skip ]
crbug.com/738854 [ Nexus_5X ] system_health.memory_mobile/load:tools:drive [ Skip ]
crbug.com/738854 [ Android_Webview ] system_health.memory_mobile/load:tools:drive [ Skip ]
crbug.com/834905 [ Nexus_5 ] system_health.memory_mobile/browse:social:pinterest_infinite_scroll [ Skip ]
crbug.com/910207 [ Nexus_5X ] system_health.memory_mobile/browse:social:pinterest_infinite_scroll [ Skip ]
crbug.com/843547 [ Android_Go ] system_health.memory_mobile/background:news:nytimes [ Skip ]
crbug.com/852888 [ Nexus_5X ] system_health.memory_mobile/background:news:nytimes [ Skip ]
crbug.com/859500 [ Nexus_5X ] system_health.memory_mobile/browse:social:tumblr_infinite_scroll [ Skip ]
......@@ -334,6 +350,7 @@ crbug.com/708300 [ Android ] v8.browsing_mobile/browse:shopping:flipkart [ Skip
[ Android_Webview ] v8.browsing_mobile/browse:chrome:omnibox [ Skip ]
[ Android_Webview ] v8.browsing_mobile/browse:chrome:newtab [ Skip ]
crbug.com/815175 [ Nexus_5 ] v8.browsing_mobile/browse:chrome:newtab [ Skip ]
crbug.com/910207 [ Nexus_5X ] v8.browsing_mobile/browse:chrome:newtab [ Skip ]
crbug.com/853212 [ Android_Webview ] v8.browsing_mobile/browse:media:youtube [ Skip ]
crbug.com/853212 [ Android_Webview ] v8.browsing_mobile/browse:news:cnn [ Skip ]
crbug.com/877648 [ Android_Go ] v8.browsing_mobile/browse:news:toi [ Skip ]
......@@ -347,6 +364,7 @@ crbug.com/708300 [ Android ] v8.browsing_mobile-future/browse:shopping:flipkart
[ Android_Webview ] v8.browsing_mobile-future/browse:chrome:omnibox [ Skip ]
[ Android_Webview ] v8.browsing_mobile-future/browse:chrome:newtab [ Skip ]
crbug.com/803465 [ Nexus_5 ] v8.browsing_mobile-future/browse:chrome:newtab [ Skip ]
crbug.com/910207 [ Nexus_5X ] v8.browsing_mobile-future/browse:chrome:newtab [ Skip ]
crbug.com/799080 [ Nexus_5X Android_Webview ] v8.browsing_mobile-future/browse:social:facebook [ Skip ]
crbug.com/799080 [ Nexus_5X Android_Webview ] v8.browsing_mobile-future/browse:social:facebook [ Skip ]
crbug.com/875159 [ Win_10 ] v8.browsing_desktop-future/browse:social:facebook_infinite_scroll [ Skip ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment