Replace PasswordManager::OnSameDocumentNavigation with

PasswordManager::OnPasswordFormSubmittedNoChecks

The OnSameDocumentNavigation forwards to OnPasswordFormSubmittedNoChecks
and because the former is the only caller of the latter
remove OnSameDocumentNavigation and replace it with
OnPasswordFormSubmittedNoChecks.

R=jdoerrie@chromium.org

Bug: 795462
Change-Id: I2097b748c630559d5922288e2d0832c8b819de83
Reviewed-on: https://chromium-review.googlesource.com/1124472
Commit-Queue: Narcis Gemene <gemene@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572246}

components/password_manager/content/browser/content_password_manager_driver.cc

@@ -236,7 +236,7 @@ void ContentPasswordManagerDriver::SameDocumentNavigation(
           render_frame_host_, password_form,
           BadMessageReason::CPMD_BAD_ORIGIN_IN_PAGE_NAVIGATION))
     return;
-  GetPasswordManager()->OnSameDocumentNavigation(this, password_form);
+  GetPasswordManager()->OnPasswordFormSubmittedNoChecks(this, password_form);
 }
 
 void ContentPasswordManagerDriver::ShowPasswordSuggestions(

components/password_manager/core/browser/password_manager.cc

@@ -869,12 +869,6 @@ void PasswordManager::OnPasswordFormsRendered(
   }
 }
 
-void PasswordManager::OnSameDocumentNavigation(
-    password_manager::PasswordManagerDriver* driver,
-    const PasswordForm& password_form) {
-  OnPasswordFormSubmittedNoChecks(driver, password_form);
-}
-
 void PasswordManager::OnLoginSuccessful() {
   std::unique_ptr<BrowserSavePasswordProgressLogger> logger;
   if (password_manager_util::IsLoggingActive(client_)) {

components/password_manager/core/browser/password_manager.h

@@ -123,6 +123,9 @@ class PasswordManager : public LoginModel, public FormSubmissionObserver {
 
   // Handles a password form being submitted, assumes that submission is
   // successful and does not do any checks on success of submission.
+  // For example, this is called if |password_form| was filled
+  // upon in-page navigation.This often means history.pushState being
+  // called from JavaScript.
   void OnPasswordFormSubmittedNoChecks(
       password_manager::PasswordManagerDriver* driver,
       const autofill::PasswordForm& password_form);
@@ -141,13 +144,6 @@ class PasswordManager : public LoginModel, public FormSubmissionObserver {
   // Handles a request to hide manual fallback for password saving.
   void HideManualFallbackForSaving();
 
-  // Called if |password_form| was filled upon in-page navigation. This often
-  // means history.pushState being called from JavaScript. If this causes false
-  // positive in password saving, update http://crbug.com/357696.
-  // TODO(https://crbug.com/795462): find better name for this function.
-  void OnSameDocumentNavigation(password_manager::PasswordManagerDriver* driver,
-                                const autofill::PasswordForm& password_form);
-
   void ProcessAutofillPredictions(
       password_manager::PasswordManagerDriver* driver,
       const std::vector<autofill::FormStructure*>& forms);

components/password_manager/core/browser/password_manager_unittest.cc

@@ -1292,7 +1292,7 @@ TEST_F(PasswordManagerTest, SameDocumentNavigation) {
   EXPECT_CALL(client_, PromptUserToSaveOrUpdatePasswordPtr(_))
       .WillOnce(WithArg<0>(SaveToScopedPtr(&form_manager_to_save)));
 
-  manager()->OnSameDocumentNavigation(&driver_, form);
+  manager()->OnPasswordFormSubmittedNoChecks(&driver_, form);
   ASSERT_TRUE(form_manager_to_save);
 
   // Simulate saving the form, as if the info bar was accepted.
@@ -1327,7 +1327,7 @@ TEST_F(PasswordManagerTest, SameDocumentBlacklistedSite) {
   EXPECT_CALL(client_, PromptUserToSaveOrUpdatePasswordPtr(_))
       .WillOnce(WithArg<0>(SaveToScopedPtr(&form_manager_to_save)));
 
-  manager()->OnSameDocumentNavigation(&driver_, form);
+  manager()->OnPasswordFormSubmittedNoChecks(&driver_, form);
   EXPECT_TRUE(form_manager_to_save->IsBlacklisted());
 }