Commit 7368cffe authored by James Cook's avatar James Cook Committed by Commit Bot

settings: Fix exception when search matches external storage management

Settings search relies on the HTML attribute associated-control to
show yellow bubbles when a search matches a sub-page.

Change the settings-subpage for external storage management to have
an associated-control at the top level of the settings page, so the
bubble appears on the Device > Storage row for a matching search.

This also prevents JS exceptions in the search code (the previous
selector didn't match any elements).

Test: On a device with Google Play Store support, open OS settings and
    search for "stor". Verify: JS console has no errors. Search field
    spinner eventually stops spinning. Yellow bubble appears over the
    Device > Storage item. Clicking search (X) clear bubble removes all
    yellow bubbles.

Bug: 1003970
Change-Id: I752eccebca599b1275fe505cff7cf561dc7ed66c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808179Reviewed-by: default avatarMichael Giuffrida <michaelpg@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697642}
parent 2dc64b39
......@@ -85,7 +85,7 @@
<template is="dom-if" if="[[androidEnabled_]]">
<template is="dom-if" route-path="/storage/externalStoragePreferences">
<settings-subpage
associated-control="[[$$('#externalStoragePreferencesRow')]]"
associated-control="[[$$('#storageRow')]]"
page-title="$i18n{storageExternal}">
<settings-storage-external prefs="{{prefs}}">
</settings-storage-external>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment