Commit 76c59958 authored by Peng Huang's avatar Peng Huang Committed by Commit Bot

Revert "Use logic rotation with SurfaceControl on Android"

This reverts commit a49d219d.

Reason for revert: Found a right way to fix it, so revert this workaround.

Original change's description:
> Use logic rotation with SurfaceControl on Android
>
> For some devices, the hardwarerotation doesn't work with SurfaceControl,
> so disable it for now.
>
> Bug: 1136033
> Change-Id: Id1ed7971d50ec815fd315fb728315f05e6be9637
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461550
> Auto-Submit: Peng Huang <penghuang@chromium.org>
> Commit-Queue: Jonathan Backer <backer@chromium.org>
> Reviewed-by: Jonathan Backer <backer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#815198}

TBR=penghuang@chromium.org,backer@chromium.org

Change-Id: Ib6f08d68ef4a99eeafd61dd01d8b5fbcb12a3a23
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1136033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462377Reviewed-by: default avatarPeng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815328}
parent a331a725
...@@ -115,12 +115,14 @@ SkiaOutputDeviceBufferQueue::SkiaOutputDeviceBufferQueue( ...@@ -115,12 +115,14 @@ SkiaOutputDeviceBufferQueue::SkiaOutputDeviceBufferQueue(
capabilities_.number_of_buffers = 3; capabilities_.number_of_buffers = 3;
capabilities_.orientation_mode = OutputSurface::OrientationMode::kHardware; capabilities_.orientation_mode = OutputSurface::OrientationMode::kHardware;
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
// With some devices, if the chrome is launched in landscape mode, the chrome // With vulkan, if the chrome is launched in landscape mode, the chrome is
// is always blank until chrome window is rotated once. Workaround this // always blank until chrome window is rotated once. Workaround this problem
// problem by using logic rotation mode. // by using logic rotation mode.
// TODO(https://crbug.com/1115065 & https://crbug.com/1136033): use hardware // TODO(https://crbug.com/1115065): use hardware orientation mode for vulkan,
// orientation mode for vulkan. if (dependency_->GetSharedContextState()->GrContextIsVulkan() &&
capabilities_.orientation_mode = OutputSurface::OrientationMode::kLogic; base::FeatureList::GetFieldTrial(features::kVulkan)) {
capabilities_.orientation_mode = OutputSurface::OrientationMode::kLogic;
}
#endif #endif
// Force the number of max pending frames to one when the switch // Force the number of max pending frames to one when the switch
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment