[uber page] Fix ignored first click on 'show advanced settings'.

BUG=none
TEST=Verify 'show/hide' advanced settings responds to click.
Review URL: https://chromiumcodereview.appspot.com/9570053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124713 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/resources/options2/browser_options.js

@@ -466,7 +466,7 @@ cr.define('options', function() {
      * @private
      */
     toggleAdvancedSettings_: function() {
-      if ($('advanced-settings').style.height == '0px')
+      if ($('advanced-settings').style.height == '')
         this.showAdvancedSettings_();
       else
         this.hideAdvancedSettings_();
@@ -479,7 +479,7 @@ cr.define('options', function() {
     showAdvancedSettings_: function() {
       $('advanced-settings').style.height =
           $('advanced-settings-container').offsetHeight + 20 + 'px';
-      $('advanced-settings-expander').innerHTML =
+      $('advanced-settings-expander').textContent =
           localStrings.getString('hideAdvancedSettings');
     },
 
@@ -488,8 +488,8 @@ cr.define('options', function() {
      * @private
      */
     hideAdvancedSettings_: function() {
-      $('advanced-settings').style.height = '0px';
-      $('advanced-settings-expander').innerHTML =
+      $('advanced-settings').style.height = '';
+      $('advanced-settings-expander').textContent =
           localStrings.getString('showAdvancedSettings');
     },