Commit 77e12ede authored by csilv@chromium.org's avatar csilv@chromium.org

[uber page] Fix ignored first click on 'show advanced settings'.

BUG=none
TEST=Verify 'show/hide' advanced settings responds to click.
Review URL: https://chromiumcodereview.appspot.com/9570053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124713 0039d316-1c4b-4281-b951-d872f2087c98
parent 84ff19fa
...@@ -466,7 +466,7 @@ cr.define('options', function() { ...@@ -466,7 +466,7 @@ cr.define('options', function() {
* @private * @private
*/ */
toggleAdvancedSettings_: function() { toggleAdvancedSettings_: function() {
if ($('advanced-settings').style.height == '0px') if ($('advanced-settings').style.height == '')
this.showAdvancedSettings_(); this.showAdvancedSettings_();
else else
this.hideAdvancedSettings_(); this.hideAdvancedSettings_();
...@@ -479,7 +479,7 @@ cr.define('options', function() { ...@@ -479,7 +479,7 @@ cr.define('options', function() {
showAdvancedSettings_: function() { showAdvancedSettings_: function() {
$('advanced-settings').style.height = $('advanced-settings').style.height =
$('advanced-settings-container').offsetHeight + 20 + 'px'; $('advanced-settings-container').offsetHeight + 20 + 'px';
$('advanced-settings-expander').innerHTML = $('advanced-settings-expander').textContent =
localStrings.getString('hideAdvancedSettings'); localStrings.getString('hideAdvancedSettings');
}, },
...@@ -488,8 +488,8 @@ cr.define('options', function() { ...@@ -488,8 +488,8 @@ cr.define('options', function() {
* @private * @private
*/ */
hideAdvancedSettings_: function() { hideAdvancedSettings_: function() {
$('advanced-settings').style.height = '0px'; $('advanced-settings').style.height = '';
$('advanced-settings-expander').innerHTML = $('advanced-settings-expander').textContent =
localStrings.getString('showAdvancedSettings'); localStrings.getString('showAdvancedSettings');
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment