Commit 7a14c043 authored by Frank Liberato's avatar Frank Liberato Committed by Commit Bot

Revert "Add debugging for virtual MakeCurrent with no decoder."

This reverts commit c812ddcd.

Reason for revert: underlying bug was fixed.

Original change's description:
> Add debugging for virtual MakeCurrent with no decoder.
> 
> Dump without crashing on Android if this happens.
> 
> Bug: 892490
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I824a4f4b9f09d3267113d6384370acae059e1690
> Reviewed-on: https://chromium-review.googlesource.com/c/1266335
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Commit-Queue: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#597385}

TBR=kbr@chromium.org,khushalsagar@chromium.org,piman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 892490
Change-Id: I9e1abd626d85a794d37f1e38fa59cb6ee827e446
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929646Reviewed-by: default avatarFrank Liberato <liberato@chromium.org>
Reviewed-by: default avatarZhenyao Mo <zmo@chromium.org>
Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Auto-Submit: Frank Liberato <liberato@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721252}
parent 79859046
......@@ -13,12 +13,6 @@
#include "ui/gl/gpu_preference.h"
#include "ui/gl/gpu_timing.h"
// TODO(crbug.com/892490): remove this once the cause of this bug is
// known.
#if defined(OS_ANDROID)
#include "base/debug/dump_without_crashing.h"
#endif
namespace gpu {
GLContextVirtual::GLContextVirtual(
......@@ -45,11 +39,6 @@ bool GLContextVirtual::MakeCurrent(gl::GLSurface* surface) {
return shared_context_->MakeVirtuallyCurrent(this, surface);
LOG(ERROR) << "Trying to make virtual context current without decoder.";
// TODO(crbug.com/892490): remove this once the cause of this bug is
// known.
#if defined(OS_ANDROID)
base::debug::DumpWithoutCrashing();
#endif
return false;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment