Commit 7ae2e5e6 authored by brettw@chromium.org's avatar brettw@chromium.org

Revert 266932 "GN build improvements."

> GN build improvements.
> 
> Fixes a TODO about private symbols on GCC.
> 
> Moves many third party BUILD.gn files from the secondary tree to the main one.
> 
> Fixes the dependencies on Linux so "gn check" passes again.
> 
> BUG=367595
> R=scottmg@chromium.org
> 
> Review URL: https://codereview.chromium.org/256153003

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/257243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266933 0039d316-1c4b-4281-b951-d872f2087c98
parent ff0811a8
...@@ -33,9 +33,7 @@ static_library("translate_core_browser") { ...@@ -33,9 +33,7 @@ static_library("translate_core_browser") {
deps = [ deps = [
":translate_core_common", ":translate_core_common",
"//base", "//base",
"//components/language_usage_metrics",
"//components/resources:components_resources", "//components/resources:components_resources",
"//net",
"//url", "//url",
] ]
} }
......
...@@ -118,8 +118,8 @@ component("libssl") { ...@@ -118,8 +118,8 @@ component("libssl") {
forward_dependent_configs_from = deps forward_dependent_configs_from = deps
} }
if (!is_win && component_mode == "shared_library") { if (component_mode == "shared_library") {
configs -= [ "//build/config/gcc:symbol_visibility_hidden" ] # TODO(brettw) GCC_SYMBOLS_PRIVATE_EXTERN thing.
} }
if (is_clang) { if (is_clang) {
......
...@@ -11,7 +11,7 @@ if (is_linux) { ...@@ -11,7 +11,7 @@ if (is_linux) {
direct_dependent_configs = [ ":expat_config" ] direct_dependent_configs = [ ":expat_config" ]
} }
# TODO(GYP) Android needs direct dependent includes of # TODO(brettw) Android needs direct dependent includes of
# <android_src>/external/expat/lib # <android_src>/external/expat/lib
} else { } else {
config("expat_config") { config("expat_config") {
......
...@@ -41,7 +41,6 @@ component("events_base") { ...@@ -41,7 +41,6 @@ component("events_base") {
":dom4_keycode_converter", ":dom4_keycode_converter",
"//base", "//base",
"//base/third_party/dynamic_annotations", "//base/third_party/dynamic_annotations",
"//ui/gfx",
"//ui/gfx/geometry", "//ui/gfx/geometry",
] ]
......
...@@ -456,10 +456,5 @@ if (use_x11) { ...@@ -456,10 +456,5 @@ if (use_x11) {
] ]
configs += [ "//build/config/linux:x11" ] configs += [ "//build/config/linux:x11" ]
deps = [
":gfx_export",
"//base"
]
} }
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment