Commit 8203406d authored by Mikel Astiz's avatar Mikel Astiz Committed by Commit Bot

Do not instantiate base::FieldTrialList explicitly in tests

The test suite already instantiates a FieldTrialList as per
https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so
it's no longer necessary to do so explicitly in tests.

This patch addresses unit tests under:
/chrome/browser/permissions

This CL was uploaded by git cl split.

R=raymes@chromium.org

Bug: 1018667
Change-Id: If47bf45568a43449af37946d1362aad9189c6803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917525
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: default avatarRaymes Khoury <raymes@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#715758}
parent f2cd82ea
...@@ -17,7 +17,6 @@ ...@@ -17,7 +17,6 @@
#include "base/metrics/field_trial_params.h" #include "base/metrics/field_trial_params.h"
#include "base/run_loop.h" #include "base/run_loop.h"
#include "base/test/metrics/histogram_tester.h" #include "base/test/metrics/histogram_tester.h"
#include "base/test/mock_entropy_provider.h"
#include "base/test/scoped_feature_list.h" #include "base/test/scoped_feature_list.h"
#include "build/build_config.h" #include "build/build_config.h"
#include "chrome/browser/content_settings/host_content_settings_map_factory.h" #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
...@@ -155,21 +154,18 @@ class TestKillSwitchPermissionContext : public TestPermissionContext { ...@@ -155,21 +154,18 @@ class TestKillSwitchPermissionContext : public TestPermissionContext {
TestKillSwitchPermissionContext( TestKillSwitchPermissionContext(
Profile* profile, Profile* profile,
const ContentSettingsType content_settings_type) const ContentSettingsType content_settings_type)
: TestPermissionContext(profile, content_settings_type), : TestPermissionContext(profile, content_settings_type) {
field_trial_list_(std::make_unique<base::FieldTrialList>( ResetFieldTrialList();
std::make_unique<base::MockEntropyProvider>())) {} }
void ResetFieldTrialList() { void ResetFieldTrialList() {
// Destroy the existing FieldTrialList before creating a new one to avoid scoped_feature_list_.Reset();
// a DCHECK. scoped_feature_list_.Init();
field_trial_list_.reset();
field_trial_list_ = std::make_unique<base::FieldTrialList>(
std::make_unique<base::MockEntropyProvider>());
variations::testing::ClearAllVariationParams(); variations::testing::ClearAllVariationParams();
} }
private: private:
std::unique_ptr<base::FieldTrialList> field_trial_list_; base::test::ScopedFeatureList scoped_feature_list_;
DISALLOW_COPY_AND_ASSIGN(TestKillSwitchPermissionContext); DISALLOW_COPY_AND_ASSIGN(TestKillSwitchPermissionContext);
}; };
......
...@@ -8,7 +8,6 @@ ...@@ -8,7 +8,6 @@
#include "base/bind.h" #include "base/bind.h"
#include "base/macros.h" #include "base/macros.h"
#include "base/test/mock_entropy_provider.h"
#include "base/test/scoped_feature_list.h" #include "base/test/scoped_feature_list.h"
#include "build/build_config.h" #include "build/build_config.h"
#include "chrome/browser/content_settings/host_content_settings_map_factory.h" #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
...@@ -649,8 +648,6 @@ TEST_F(PermissionManagerTest, KillSwitchOnIsNotOverridable) { ...@@ -649,8 +648,6 @@ TEST_F(PermissionManagerTest, KillSwitchOnIsNotOverridable) {
PermissionType::GEOLOCATION, kLocalHost)); PermissionType::GEOLOCATION, kLocalHost));
// Turn on kill switch for GEOLOCATION. // Turn on kill switch for GEOLOCATION.
base::FieldTrialList field_trial_list(
std::make_unique<base::MockEntropyProvider>());
variations::testing::ClearAllVariationParams(); variations::testing::ClearAllVariationParams();
std::map<std::string, std::string> params; std::map<std::string, std::string> params;
params[PermissionUtil::GetPermissionString( params[PermissionUtil::GetPermissionString(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment