Commit 826d62f9 authored by Anita Woodruff's avatar Anita Woodruff Committed by Commit Bot

[Cleanup] Remove TODO in NotificationChannelsProviderAndroid

This TODO was already addressed as part of https://crrev.com/c/1030332
- we now only create the NCPA when not in incognito mode.

R=peter@chromium.org

Bug: 835232
Change-Id: I4023252075c177a5741e8a90f86b2144a8ae5f18
Reviewed-on: https://chromium-review.googlesource.com/1160301Reviewed-by: default avatarPeter Beverloo <peter@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580139}
parent 66c0582d
...@@ -400,8 +400,6 @@ base::Time NotificationChannelsProviderAndroid::GetWebsiteSettingLastModified( ...@@ -400,8 +400,6 @@ base::Time NotificationChannelsProviderAndroid::GetWebsiteSettingLastModified(
void NotificationChannelsProviderAndroid::CreateChannelIfRequired( void NotificationChannelsProviderAndroid::CreateChannelIfRequired(
const std::string& origin_string, const std::string& origin_string,
NotificationChannelStatus new_channel_status) { NotificationChannelStatus new_channel_status) {
// TODO(awdf): Maybe check cached incognito status here to make sure
// channels are never created in incognito mode.
auto channel_entry = cached_channels_.find(origin_string); auto channel_entry = cached_channels_.find(origin_string);
if (channel_entry == cached_channels_.end()) { if (channel_entry == cached_channels_.end()) {
base::Time timestamp = clock_->Now(); base::Time timestamp = clock_->Now();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment