Commit 86bdbfd2 authored by Ian Vollick's avatar Ian Vollick Committed by Commit Bot

Revert "[vr] Disable WillNotFailOnNonAsciiURLs"

This reverts commit a2ce72e4.

Reason for revert: this test should now pass.

Original change's description:
> [vr] Disable WillNotFailOnNonAsciiURLs
> 
> This will currently not pass with new versions of HarfBuzz.
> 
> Bug: 731894
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: Ib5ae456bf44bfdedd6a0edf36b54dbbf12bae18a
> Reviewed-on: https://chromium-review.googlesource.com/1169774
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582298}

TBR=vollick@chromium.org,mthiesse@chromium.org,eae@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 731894
Change-Id: Id02d8c770a763c5c37f993d701d03e518a043ee7
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1178164Reviewed-by: default avatarIan Vollick <vollick@chromium.org>
Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584018}
parent 9f5af185
......@@ -10,10 +10,10 @@
namespace vr {
#if !defined(OS_LINUX) && !defined(OS_WIN)
// TODO(crbug/731894): This test does not work on Linux.
// TODO(crbug/770893): This test does not work on Windows.
// TODO(crbug/731894): This test does not work on Android, either.
TEST(UrlText, DISABLED_WillNotFailOnNonAsciiURLs) {
TEST(UrlText, WillNotFailOnNonAsciiURLs) {
bool unhandled_code_point = false;
auto url_text = std::make_unique<UrlText>(
0.010, base::BindRepeating([](bool* flag) { *flag = true; },
......@@ -23,6 +23,7 @@ TEST(UrlText, DISABLED_WillNotFailOnNonAsciiURLs) {
url_text->PrepareToDrawForTest();
EXPECT_EQ(false, unhandled_code_point);
}
#endif
TEST(UrlText, WillFailOnUnhandledCodePoint) {
bool unhandled_code_point;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment