Commit 8855c4f3 authored by Maksim Ivanov's avatar Maksim Ivanov Committed by Commit Bot

Fix use-after-move in //components/services/paint_preview_compositor/

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: Iecad2dc339be6d352c3cf420a50b3f9c58cbe68f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382594
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: default avatarCalder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803099}
parent 27aeb845
...@@ -144,6 +144,7 @@ void PaintPreviewCompositorImpl::BeginSeparatedFrameComposite( ...@@ -144,6 +144,7 @@ void PaintPreviewCompositorImpl::BeginSeparatedFrameComposite(
std::move(callback).Run(mojom::PaintPreviewCompositor:: std::move(callback).Run(mojom::PaintPreviewCompositor::
BeginCompositeStatus::kDeserializingFailure, BeginCompositeStatus::kDeserializingFailure,
std::move(response)); std::move(response));
return;
} }
auto frames = DeserializeAllFrames(std::move(request->recording_map)); auto frames = DeserializeAllFrames(std::move(request->recording_map));
...@@ -216,6 +217,7 @@ void PaintPreviewCompositorImpl::BeginMainFrameComposite( ...@@ -216,6 +217,7 @@ void PaintPreviewCompositorImpl::BeginMainFrameComposite(
DVLOG(1) << "No valid root frame guid"; DVLOG(1) << "No valid root frame guid";
std::move(callback).Run(mojom::PaintPreviewCompositor:: std::move(callback).Run(mojom::PaintPreviewCompositor::
BeginCompositeStatus::kDeserializingFailure); BeginCompositeStatus::kDeserializingFailure);
return;
} }
base::flat_map<base::UnguessableToken, sk_sp<SkPicture>> loaded_frames; base::flat_map<base::UnguessableToken, sk_sp<SkPicture>> loaded_frames;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment